Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bat test #1226

Merged
merged 10 commits into from
Mar 18, 2022
Merged

Bat test #1226

merged 10 commits into from
Mar 18, 2022

Conversation

edmundmiller
Copy link
Contributor

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • PROFILE=docker pytest --tag <MODULE> --symlink --keep-workflow-wd
    • PROFILE=singularity pytest --tag <MODULE> --symlink --keep-workflow-wd
    • PROFILE=conda pytest --tag <MODULE> --symlink --keep-workflow-wd

@grst
Copy link
Member

grst commented Jan 21, 2022

ok, I can live with that:
https://github.com/nf-core/modules/runs/4893376089?check_suite_focus=true

Any way we could also highlight the pytest workflow output one step earlier?

EDIT:

  • eventually, just git revert bc78e5e

@edmundmiller
Copy link
Contributor Author

I'm going to guess we need to configure pytest. Does nf-core/tools use colored output? Ah yes, it does. --color=yes

@edmundmiller edmundmiller marked this pull request as ready for review February 7, 2022 16:35
@edmundmiller edmundmiller requested a review from grst February 7, 2022 16:35
Copy link
Member

@grst grst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

The markdownlint failure is unrelated (npm stuff) so we can ignore that!

@edmundmiller edmundmiller merged commit 7436eeb into master Mar 18, 2022
@edmundmiller edmundmiller deleted the bat-test branch March 18, 2022 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants