Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tools 2.7.1 merge #288

Merged
merged 5 commits into from
Dec 15, 2022
Merged

Tools 2.7.1 merge #288

merged 5 commits into from
Dec 15, 2022

Conversation

ewels
Copy link
Member

@ewels ewels commented Dec 11, 2022

Fixes merge conflicts in #287

#287 should automatically show as merged when this PR is merged. Keeping them separate so that it's easier to compare diffs.

@ewels ewels marked this pull request as ready for review December 11, 2022 19:30
@github-actions
Copy link

github-actions bot commented Dec 11, 2022 •
edited
Loading

nf-core lint overall result: Passed ✅

Posted for pipeline commit 1a1d68f

+| ✅ 157 tests passed       |+

✅ Tests passed:

Run details

  • nf-core/tools version 2.7.1
  • Run at 2022-12-15 22:41:03

njspix
njspix reviewed Dec 15, 2022
View reviewed changes
Copy link
Contributor

@njspix njspix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was hoping to be helpful, but since many of the changes are in the .github magic (which I don't understand very well), I'm afraid I don't have much to contribute.
but if you need a rubber stamp I'm happy to be that! 😄

@ewels
Copy link
Member Author

ewels commented Dec 15, 2022

Thanks @njspix!

I'm a bit worries that the tests are taking many hours to run.. Might be worth investigating before I merge.. 🤔

edmundmiller
edmundmiller approved these changes Dec 15, 2022
View reviewed changes
Copy link
Collaborator

@edmundmiller edmundmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@ewels
Copy link
Member Author

ewels commented Dec 15, 2022

Tests were hanging due to nf-core/tools#2132

Reverted change, should hopefully pass again now.

@ewels
Copy link
Member Author

ewels commented Dec 15, 2022

That's better!

@ewels ewels merged commit dec70a2 into nf-core:dev Dec 15, 2022
@ewels ewels deleted the tools-2.7.1-merge branch December 15, 2022 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njspix njspix njspix approved these changes

@edmundmiller edmundmiller edmundmiller approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ewels @edmundmiller @njspix @nf-core-bot