Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow non-gzipped fastq input #93

Merged
merged 6 commits into from
Nov 15, 2024
Merged

fix: allow non-gzipped fastq input #93

merged 6 commits into from
Nov 15, 2024

Conversation

znorgaard
Copy link
Collaborator

@znorgaard znorgaard commented Nov 14, 2024

Closes #91

This PR allows for the use of .fastq or .fq files instead of requiring gzipped files.

Tested locally by copying and unzipping the test data for the tiny samplesheet test.
https://raw.githubusercontent.com/nf-core/test-datasets/fastquorum/testdata/samplesheets/samplesheet.tiny.csv

Not sure if we want to add a specific test for non-gzipped input.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If necessary, also make a PR on the nf-core/fastquorum branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nf-test test main.nf.test -profile test,docker).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • CHANGELOG.md is updated.

Copy link

github-actions bot commented Nov 14, 2024

nf-core pipelines lint overall result: Passed ✅ ⚠️

Posted for pipeline commit c164e1f

+| ✅ 193 tests passed       |+
#| ❔   8 tests were ignored |#
!| ❗   1 tests had warnings |!

❗ Test warnings:

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 3.0.2
  • Run at 2024-11-14 19:10:46

Copy link
Contributor

@SPPearce SPPearce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not worried about adding an extra test for this.

@znorgaard znorgaard merged commit aea8d31 into zn_conda Nov 15, 2024
4 checks passed
@znorgaard znorgaard deleted the zn_fastq branch November 15, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants