Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: release 1.1.0 #89

Merged
merged 56 commits into from
Dec 2, 2024
Merged

chore: release 1.1.0 #89

merged 56 commits into from
Dec 2, 2024

Conversation

znorgaard
Copy link
Collaborator

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/fastquorum branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nf-test test main.nf.test -profile test,docker).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

znorgaard and others added 29 commits September 11, 2024 08:46
fix: output bai from ALIGN_CONSENSUS_BAM
Template update for nf-core/tools version 3.0.1

Template update for nf-core/tools version 3.0.2
chore: template update for nf-core/tools version 3.0.2
fix: align versioning across tests and config
chore: prepare for release
@znorgaard znorgaard requested a review from SPPearce November 6, 2024 16:27
@znorgaard znorgaard requested a review from SPPearce November 15, 2024 17:44
Copy link
Contributor

@SPPearce SPPearce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@SPPearce SPPearce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, apart from the fact that the download test is failing 😞

@SPPearce
Copy link
Contributor

Although I see @MatthiasZepper is already involved in looking at that.

@MatthiasZepper
Copy link
Member

MatthiasZepper commented Nov 23, 2024

Although I see @MatthiasZepper is already involved in looking at that.

Yes, the botched Seqera Containers roll-out is keeping me up on my toes. But the error here was nicely troubleshooted, pinpointed and reported by @znorgaard, so I could fix it. The download will work, once this PR is merged to tools and already does, when the action from the dev branch is used instead the version from master.

I do really not know how to proceed, if one doesn't want to wait for the tools update. I think, in this case, it would be fine to merge with a failing test? Otherwise, it is a hen and an egg problem: To merge dev to master, you need to pass the test version on master, that will be corrected with the merge from dev.

@SPPearce
Copy link
Contributor

Happy to merge with the failed test then, if it'll be fixed anyway. Although that'll require someone with more permissions than me.

@MatthiasZepper
Copy link
Member

MatthiasZepper commented Dec 2, 2024

@znorgaard: nf-core download patch was reviewed and merged earlier today, so the test is now passing. Currently, on dev (sufficient for making the test pass), but there is a 3.1 release of nf-core tools expected some when later this week, so ordinary people will also be able to successfully download the pipeline.

Happy fastquorum releasing!

Comment on lines +198 to +224
ch_multiqc_config = Channel.fromPath(
"$projectDir/assets/multiqc_config.yml", checkIfExists: true)
ch_multiqc_custom_config = params.multiqc_config ?
Channel.fromPath(params.multiqc_config, checkIfExists: true) :
Channel.empty()
ch_multiqc_logo = params.multiqc_logo ?
Channel.fromPath(params.multiqc_logo, checkIfExists: true) :
Channel.empty()

summary_params = paramsSummaryMap(
workflow, parameters_schema: "nextflow_schema.json")
ch_workflow_summary = Channel.value(paramsSummaryMultiqc(summary_params))
ch_multiqc_files = ch_multiqc_files.mix(
ch_workflow_summary.collectFile(name: 'workflow_summary_mqc.yaml'))
ch_multiqc_custom_methods_description = params.multiqc_methods_description ?
file(params.multiqc_methods_description, checkIfExists: true) :
file("$projectDir/assets/methods_description_template.yml", checkIfExists: true)
ch_methods_description = Channel.value(
methodsDescriptionText(ch_multiqc_custom_methods_description))

ch_multiqc_files = ch_multiqc_files.mix(ch_collated_versions)
ch_multiqc_files = ch_multiqc_files.mix(
ch_methods_description.collectFile(
name: 'methods_description_mqc.yaml',
sort: true
)
)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The syntax formatting here makes this an especially difficult section to read/review.

Could we format this?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#97

CHANGELOG.md Outdated
| samtools/faidx | 04fbbc7 | b13f07b |
| samtools/merge | 04fbbc7 | b13f07b |

- [PR #87](https://github.com/nf-core/fastquorum/pull/87) - Raise minimum version to 24.04.2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- [PR #87](https://github.com/nf-core/fastquorum/pull/87) - Raise minimum version to 24.04.2
- [PR #87](https://github.com/nf-core/fastquorum/pull/87) - Raise minimum Nextflow version to 24.04.2

@clintval clintval assigned znorgaard and unassigned clintval Dec 2, 2024
@znorgaard znorgaard changed the title chore: release 1.0.2 chore: release 1.1.0 Dec 2, 2024
@znorgaard znorgaard merged commit 1f6d25f into master Dec 2, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants