-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: release 1.1.0 #89
Conversation
chore: bump dev version
fix: output bai from ALIGN_CONSENSUS_BAM
fix: file glob
Template update for nf-core/tools version 3.0.1 Template update for nf-core/tools version 3.0.2
chore: template update for nf-core/tools version 3.0.2
chore: raise minimum version
fix: lower config min version
fix: align versioning across tests and config
chore: prepare for release
fix: conda environments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
fix: limit downloads
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, apart from the fact that the download test is failing 😞
Although I see @MatthiasZepper is already involved in looking at that. |
Yes, the botched Seqera Containers roll-out is keeping me up on my toes. But the error here was nicely troubleshooted, pinpointed and reported by @znorgaard, so I could fix it. The download will work, once this PR is merged to tools and already does, when the action from the dev branch is used instead the version from master. I do really not know how to proceed, if one doesn't want to wait for the tools update. I think, in this case, it would be fine to merge with a failing test? Otherwise, it is a hen and an egg problem: To merge |
Happy to merge with the failed test then, if it'll be fixed anyway. Although that'll require someone with more permissions than me. |
@znorgaard: Happy fastquorum releasing! |
ch_multiqc_config = Channel.fromPath( | ||
"$projectDir/assets/multiqc_config.yml", checkIfExists: true) | ||
ch_multiqc_custom_config = params.multiqc_config ? | ||
Channel.fromPath(params.multiqc_config, checkIfExists: true) : | ||
Channel.empty() | ||
ch_multiqc_logo = params.multiqc_logo ? | ||
Channel.fromPath(params.multiqc_logo, checkIfExists: true) : | ||
Channel.empty() | ||
|
||
summary_params = paramsSummaryMap( | ||
workflow, parameters_schema: "nextflow_schema.json") | ||
ch_workflow_summary = Channel.value(paramsSummaryMultiqc(summary_params)) | ||
ch_multiqc_files = ch_multiqc_files.mix( | ||
ch_workflow_summary.collectFile(name: 'workflow_summary_mqc.yaml')) | ||
ch_multiqc_custom_methods_description = params.multiqc_methods_description ? | ||
file(params.multiqc_methods_description, checkIfExists: true) : | ||
file("$projectDir/assets/methods_description_template.yml", checkIfExists: true) | ||
ch_methods_description = Channel.value( | ||
methodsDescriptionText(ch_multiqc_custom_methods_description)) | ||
|
||
ch_multiqc_files = ch_multiqc_files.mix(ch_collated_versions) | ||
ch_multiqc_files = ch_multiqc_files.mix( | ||
ch_methods_description.collectFile( | ||
name: 'methods_description_mqc.yaml', | ||
sort: true | ||
) | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The syntax formatting here makes this an especially difficult section to read/review.
Could we format this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CHANGELOG.md
Outdated
| samtools/faidx | 04fbbc7 | b13f07b | | ||
| samtools/merge | 04fbbc7 | b13f07b | | ||
|
||
- [PR #87](https://github.com/nf-core/fastquorum/pull/87) - Raise minimum version to 24.04.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- [PR #87](https://github.com/nf-core/fastquorum/pull/87) - Raise minimum version to 24.04.2 | |
- [PR #87](https://github.com/nf-core/fastquorum/pull/87) - Raise minimum Nextflow version to 24.04.2 |
chore: set release date
chore: version bump
Update nf-core components to latest versions
PR checklist
nf-core lint
).nf-test test main.nf.test -profile test,docker
).nextflow run . -profile debug,test,docker --outdir <OUTDIR>
).docs/usage.md
is updated.docs/output.md
is updated.CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).