Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Samtools indexing for large reference genomes #147

Merged
merged 8 commits into from
Feb 26, 2019

Conversation

apeltzer
Copy link
Member

This addresses #146 , where the contig sizes are too long for the regular BAI indices used in the default samtools index process. x-ref https://www.biostars.org/p/111984/ it doesn't really harm to use CSI indices, so I just use these now everywhere instead, which should work both on smaller and larger reference genomes without issues 👍

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • If necessary, also make a PR on the nf-core/eager branch on the nf-core/test-datasets repo
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: https://github.com/nf-core/eager/tree/master/.github/CONTRIBUTING.md

Copy link
Member

@jfy133 jfy133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment on #146 (comment)

@apeltzer apeltzer merged commit ee3c44f into nf-core:dev Feb 26, 2019
@apeltzer apeltzer deleted the fix-samtools-idx branch February 26, 2019 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants