Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.10.0 #755

Merged
merged 57 commits into from
Jun 27, 2024
Merged

Release 2.10.0 #755

merged 57 commits into from
Jun 27, 2024

Conversation

d4straub
Copy link
Collaborator

@d4straub d4straub commented Jun 25, 2024

This release contains a few updates to the reference taxonomy databases, nf-core template update 2.14.1, better differential abundance analysis tools, and some bug fixes. For details please check the CHANGELOG!

Besides reviews, before merging I will confirm that:

  • the new parameter section on the website is fine
  • the AWS test succeeds

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/ampliseq branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nf-test test main.nf.test -profile test,docker).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

d4straub and others added 30 commits April 3, 2024 15:40
After release PR - bump version to 2.10.0dev
Fix misleading error message and documentation
Co-authored-by: Daniel Lundin <erik.rikard.daniel@gmail.com>
Copy link

github-actions bot commented Jun 25, 2024

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit a1511ef

+| ✅ 284 tests passed       |+
#| ❔   6 tests were ignored |#
!| ❗   2 tests had warnings |!

❗ Test warnings:

  • nextflow_config - Config manifest.version should end in dev: 2.10.0
  • readme - README did not have a Nextflow minimum version badge.

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.14.1
  • Run at 2024-06-27 07:33:32

Copy link

@jannikseidelQBiC jannikseidelQBiC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just minor visual complaints (harshil alignment in some of the local modules and subworkflows), but I leave it to you to decide if this should be changed. Well done!

Copy link
Member

@erikrikarddaniel erikrikarddaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@d4straub d4straub merged commit 3f40a1b into master Jun 27, 2024
66 checks passed
@d4straub
Copy link
Collaborator Author

Thanks for the reviews!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants