Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies #646

Merged
merged 7 commits into from
Oct 17, 2023
Merged

Update dependencies #646

merged 7 commits into from
Oct 17, 2023

Conversation

d4straub
Copy link
Collaborator

@d4straub d4straub commented Oct 16, 2023 •
edited
Loading

Updated FASTQC, DADA2, PICRUSt2, QIIME2 (see changelog).

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/ampliseq branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link

github-actions bot commented Oct 16, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 5c8c7c4

+| ✅ 154 tests passed       |+
#| ❔   3 tests were ignored |#
!| ❗   2 tests had warnings |!

❗ Test warnings:

  • readme - README did not have a Nextflow minimum version badge.
  • schema_lint - Parameter input is not defined in the correct subschema (input_output_options)

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.10
  • Run at 2023-10-17 06:16:47

tillenglert
tillenglert approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@tillenglert tillenglert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :) I am not quite sure how the nf-test stuff works! So if you are unsure about them please wait for another review ;)

@d4straub
Copy link
Collaborator Author

Nah, I am sure the nf-tests are fine ;)
Thanks for the review!

@d4straub d4straub merged commit 0227a31 into nf-core:dev Oct 17, 2023
@d4straub d4straub deleted the update-dependencies branch October 17, 2023 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tillenglert tillenglert tillenglert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@d4straub @tillenglert