Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update QIIME2 from 2022.8 to 2022.11 #528

Merged
merged 1 commit into from
Feb 1, 2023
Merged

Update QIIME2 from 2022.8 to 2022.11 #528

merged 1 commit into from
Feb 1, 2023

Conversation

d4straub
Copy link
Collaborator

@d4straub d4straub commented Jan 31, 2023 •
edited
Loading

This might fix #516 edit: unfortunately it doesnt!
The size of the new container is 1/3 of the old container, already this is a stark argument.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs- [ ] If necessary, also make a PR on the nf-core/ampliseq branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link

github-actions bot commented Jan 31, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 3d0202e

+| ✅ 155 tests passed       |+
#| ❔   1 tests were ignored |#
!| ❗   2 tests had warnings |!

❗ Test warnings:

  • readme - README did not have a Nextflow minimum version badge.
  • schema_lint - Parameter input is not defined in the correct subschema (input_output_options)

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.7.2
  • Run at 2023-01-31 13:34:37

erikrikarddaniel
erikrikarddaniel approved these changes Feb 1, 2023
View reviewed changes
Copy link
Member

@erikrikarddaniel erikrikarddaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@d4straub
Copy link
Collaborator Author

d4straub commented Feb 1, 2023

Thanks!

@d4straub d4straub merged commit 0b4d188 into nf-core:dev Feb 1, 2023
@d4straub d4straub deleted the update-qiime-to-2022.11 branch February 1, 2023 08:40
@github-actions
Copy link

github-actions bot commented Feb 1, 2023

Python linting (black) is failing

To keep the code consistent with lots of contributors, we run automated code consistency checks.
To fix this CI test, please run:

  • Install black: pip install black
  • Fix formatting errors in your pipeline: black .

Once you push these changes the test should pass, and you can hide this comment 👍

We highly recommend setting up Black in your code editor so that this formatting is done automatically on save. Ask about it on Slack for help!

Thanks again for your contribution!

@d4straub
Copy link
Collaborator Author

d4straub commented Feb 1, 2023

I dont get why black is complaining NOW and not at the appropriate time when the test run here in the PR. Will fix it soonish.

@d4straub d4straub mentioned this pull request Feb 2, 2023
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikrikarddaniel erikrikarddaniel erikrikarddaniel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@d4straub @erikrikarddaniel