Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change border radius in modals of the inputables #2559

Conversation

yvmunayev
Copy link
Contributor

fix: #2543

Changes proposed in this PR:

@nexxtway/react-rainbow

@commit-lint
Copy link

commit-lint bot commented Dec 6, 2022

Bug Fixes

  • change border radius in modals of the inputables (fa9b6a6)
  • remove internalOverlay example (4ecaf54)

Contributors

yvmunayev, LeandroTorresSicilia

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@yvmunayev
Copy link
Contributor Author

@LeandroTorresSicilia The InternalOverlay component does not handle how to paint the border radius, it only calculates the position. Add an example of how you can do an InternalOverlay with border radius.

@github-actions
Copy link

github-actions bot commented Dec 6, 2022

Visit the preview URL for this PR (updated for commit bf05f06):

https://react-rainbow--pr2559-fix-change-border-ra-zzaz9x7v.web.app

(expires Thu, 29 Dec 2022 23:09:15 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 2de6d670498a0a515484c5637b13d0215372df83

@codeclimate
Copy link

codeclimate bot commented Dec 22, 2022

Code Climate has analyzed commit bf05f06 and detected 3 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 3

View more on Code Climate.

@LeandroTorresSicilia LeandroTorresSicilia merged commit 21d5ba6 into master Dec 22, 2022
@LeandroTorresSicilia LeandroTorresSicilia deleted the fix-change-border-radius-in-modals-of-the-inputables branch December 22, 2022 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: change border radius in modals of the inputables
2 participants