Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: add unit test to percent input #2489

Merged
merged 9 commits into from
Oct 22, 2022

Conversation

yvmunayev
Copy link
Contributor

fix: #2487

Changes proposed in this PR:

@nexxtway/react-rainbow

@commit-lint
Copy link

commit-lint bot commented Oct 18, 2022

Tests

  • add unit test to currency input (b9f2699)
  • add unit tests to percent input (3c5fa26)

Bug Fixes

  • some lint error (0bb8d67)
  • change name of isValidNumberValue function (05e8f22)
  • change name of isValidNumberValue function (bf8fdf3)

Contributors

yvmunayev, LeandroTorresSicilia

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

return <CurrencyInput onChange={setValue} value={value} />;
};

describe('<CurrencyInput />', () => {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar blocks of code found in 2 locations. Consider refactoring.

return <PercentInput onChange={setValue} value={value} />;
};

describe('<PercentInput />', () => {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar blocks of code found in 2 locations. Consider refactoring.


import CurrencyInput from '..';

const TestCurrencyInput = props => {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar blocks of code found in 2 locations. Consider refactoring.


import PercentInput from '..';

const TestPercentInput = props => {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar blocks of code found in 2 locations. Consider refactoring.

@github-actions
Copy link

github-actions bot commented Oct 18, 2022

Visit the preview URL for this PR (updated for commit 9f6f485):

https://react-rainbow--pr2489-tests-add-unit-test-1f0x4vi1.web.app

(expires Sat, 29 Oct 2022 16:21:52 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 2de6d670498a0a515484c5637b13d0215372df83

@codeclimate
Copy link

codeclimate bot commented Oct 22, 2022

Code Climate has analyzed commit 9f6f485 and detected 4 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 4

View more on Code Climate.

@LeandroTorresSicilia LeandroTorresSicilia merged commit 15cca49 into master Oct 22, 2022
@LeandroTorresSicilia LeandroTorresSicilia deleted the tests-add-unit-test-to-percent-input branch October 22, 2022 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tests: add unit tests to percent input
2 participants