feat: add currency input component #2468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to feat-add-currency-input-component
FeaturesContributorsCommit-Lint commandsYou can trigger Commit-Lint actions by commenting on this PR:
|
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
|
Code Climate has analyzed commit 6fb65be and detected 11 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
|
Visit the preview URL for this PR (updated for commit 6fb65be): https://react-rainbow--pr2468-feat-add-currency-in-coeu1fdp.web.app (expires Fri, 14 Oct 2022 20:17:08 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
| const formattedInteger = formatInteger(stringInteger, locale, options); | ||
|
|
||
| return stringValue.indexOf('.') !== -1 | ||
| ? `${formattedInteger}${decimalSeparator}${stringDecimal || ''}` |
There was a problem hiding this comment.
this manual construction maybe does not work with other locales
| } = useReduxForm(props); | ||
|
|
||
| const inputRef = useRef(); | ||
| const inputId = useUniqueIdentifier('counter-input'); |
1 task
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #2467
Changes proposed in this PR:
feat: add currency input component
I have followed (at least) the PR section of the contributing guide.
@nexxtway/react-rainbow