-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(deps): bump @tanstack/react-virtual
to support react 19 peer dep
#4463
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 3f38224 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
WalkthroughThis pull request focuses on updating dependencies across multiple packages. The primary changes involve bumping the version of Changes
Possibly related PRs
Suggested reviewers
📜 Recent review detailsConfiguration used: .coderabbit.yaml ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (4)
✅ Files skipped from review due to trivial changes (1)
🔇 Additional comments (3)packages/components/listbox/package.json (1)
The version bump from 3.10.9 to 3.11.2 aligns with the PR objective to support React 19. Let's verify there are no breaking changes. ✅ Verification successfulLet me gather more information about the changes in these versions. Version upgrade to @tanstack/react-virtual 3.11.2 is safe The version changes from 3.10.9 to 3.11.2 contain:
All changes are backwards compatible and include bug fixes and React 19 support, which aligns with the PR objective. 🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Check for breaking changes in @tanstack/react-virtual changelog
# Get the changelog or release notes
gh api repos/tanstack/virtual/releases | jq -r '.[].body' | grep -A 5 "3.11.0\|3.11.1\|3.11.2"
Length of output: 722 Script: #!/bin/bash
# Description: Get detailed changelog for versions 3.11.0 through 3.11.2
# Get the full release notes without grep to see complete entries
gh api repos/tanstack/virtual/releases | jq -r '.[] | select(.tag_name | startswith("v3.11.")) | "Version: \(.tag_name)\n\(.body)\n---"'
Length of output: 1752 packages/components/select/package.json (1)
The version update to 3.11.2 matches the listbox package. Since this package depends on @nextui-org/listbox, this consistency is crucial to avoid version conflicts. apps/docs/package.json (1)
While the @tanstack/react-virtual update supports React 19, the docs app is currently pinned to React 18.2.0 through pnpm overrides. This is fine as the new version supports both React 18 and 19. ✅ Verification successfulReact version compatibility is maintained across the codebase The verification shows that all internal packages in the repository support both React 18 and React 19 (>=18 || >=19.0.0-rc.0). The docs app being pinned to React 18.2.0 through overrides is a deliberate choice and doesn't cause compatibility issues since:
🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Check for React version compatibility issues
# Check if any dependencies require React 19
rg "\"react\".*19" -g "package.json"
# Check for potential version conflicts
pnpm why @tanstack/react-virtual
Length of output: 6127 Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Closes #
📝 Description
reported by discord user here
@tanstack/react-virtual
team made a release to support that 3 weeks ago. Hence, this PR is to bump the latest version of that.⛳️ Current behavior (updates)
🚀 New behavior
💣 Is this a breaking change (Yes/No):
📝 Additional Information
Summary by CodeRabbit
Dependency Updates
@tanstack/react-virtual
to version 3.11.2 across multiple packages@nextui-org/listbox
and@nextui-org/select
Compatibility