Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): bump @tanstack/react-virtual to support react 19 peer dep #4463

Merged
merged 1 commit into from
Dec 30, 2024

Conversation

wingkwong
Copy link
Member

@wingkwong wingkwong commented Dec 30, 2024

Closes #

📝 Description

reported by discord user here

image

@tanstack/react-virtual team made a release to support that 3 weeks ago. Hence, this PR is to bump the latest version of that.

⛳️ Current behavior (updates)

🚀 New behavior

💣 Is this a breaking change (Yes/No):

📝 Additional Information

Summary by CodeRabbit

  • Dependency Updates

    • Updated @tanstack/react-virtual to version 3.11.2 across multiple packages
    • Added patch versions for @nextui-org/listbox and @nextui-org/select
  • Compatibility

    • Ensured compatibility with React version 19 peer dependency

@wingkwong wingkwong added this to the v2.6.11 milestone Dec 30, 2024
@wingkwong wingkwong requested a review from vinroger December 30, 2024 12:19
Copy link

vercel bot commented Dec 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nextui-docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 30, 2024 0:32am
nextui-storybook-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 30, 2024 0:32am

Copy link

changeset-bot bot commented Dec 30, 2024

🦋 Changeset detected

Latest commit: 3f38224

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@nextui-org/listbox Patch
@nextui-org/select Patch
@nextui-org/autocomplete Patch
@nextui-org/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

coderabbitai bot commented Dec 30, 2024

Walkthrough

This pull request focuses on updating dependencies across multiple packages. The primary changes involve bumping the version of @tanstack/react-virtual from 3.10.9 to 3.11.2 in several package.json files, including docs, listbox, and select packages. Additionally, patches for @nextui-org/listbox and @nextui-org/select are introduced to ensure compatibility, potentially addressing React version 19 support.

Changes

File Change Summary
.changeset/hip-ligers-rhyme.md Added patches for @nextui-org/listbox and @nextui-org/select
apps/docs/package.json Updated @tanstack/react-virtual to 3.11.2
packages/components/listbox/package.json Updated @tanstack/react-virtual to 3.11.2
packages/components/select/package.json Updated @tanstack/react-virtual to 3.11.2

Possibly related PRs

Suggested reviewers

  • jrgarciadev

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fb46df2 and 3f38224.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (4)
  • .changeset/hip-ligers-rhyme.md (1 hunks)
  • apps/docs/package.json (1 hunks)
  • packages/components/listbox/package.json (1 hunks)
  • packages/components/select/package.json (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • .changeset/hip-ligers-rhyme.md
🔇 Additional comments (3)
packages/components/listbox/package.json (1)

48-48: Verify breaking changes in @tanstack/react-virtual upgrade

The version bump from 3.10.9 to 3.11.2 aligns with the PR objective to support React 19. Let's verify there are no breaking changes.

✅ Verification successful

Let me gather more information about the changes in these versions.


Version upgrade to @tanstack/react-virtual 3.11.2 is safe

The version changes from 3.10.9 to 3.11.2 contain:

  • 3.11.0: Added React 19 support to peer dependencies
  • 3.11.1: Fixed _didMount to use useIsomorphicLayoutEffect
  • 3.11.2: Fixed scroll-to-index center alignment

All changes are backwards compatible and include bug fixes and React 19 support, which aligns with the PR objective.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check for breaking changes in @tanstack/react-virtual changelog

# Get the changelog or release notes
gh api repos/tanstack/virtual/releases | jq -r '.[].body' | grep -A 5 "3.11.0\|3.11.1\|3.11.2"

Length of output: 722


Script:

#!/bin/bash
# Description: Get detailed changelog for versions 3.11.0 through 3.11.2

# Get the full release notes without grep to see complete entries
gh api repos/tanstack/virtual/releases | jq -r '.[] | select(.tag_name | startswith("v3.11.")) | "Version: \(.tag_name)\n\(.body)\n---"'

Length of output: 1752

packages/components/select/package.json (1)

62-62: Version consistency with @nextui-org/listbox dependency

The version update to 3.11.2 matches the listbox package. Since this package depends on @nextui-org/listbox, this consistency is crucial to avoid version conflicts.

apps/docs/package.json (1)

56-56: Verify React version compatibility in docs app

While the @tanstack/react-virtual update supports React 19, the docs app is currently pinned to React 18.2.0 through pnpm overrides. This is fine as the new version supports both React 18 and 19.

✅ Verification successful

React version compatibility is maintained across the codebase

The verification shows that all internal packages in the repository support both React 18 and React 19 (>=18 || >=19.0.0-rc.0). The docs app being pinned to React 18.2.0 through overrides is a deliberate choice and doesn't cause compatibility issues since:

  • @tanstack/react-virtual 3.11.2 supports both React 18 and 19
  • All internal dependencies are compatible with React 18
  • No dependencies explicitly require React 19
🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check for React version compatibility issues

# Check if any dependencies require React 19
rg "\"react\".*19" -g "package.json"

# Check for potential version conflicts
pnpm why @tanstack/react-virtual

Length of output: 6127


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@wingkwong wingkwong removed the request for review from jrgarciadev December 30, 2024 12:19
@jrgarciadev jrgarciadev merged commit d92468a into canary Dec 30, 2024
8 checks passed
@jrgarciadev jrgarciadev deleted the fix/react-virtual-dep branch December 30, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants