-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(docs): highlighted line in Select dynamic items #3838
Conversation
The wrong highlight wasted me 1 hour to fix the null error
|
@Choneas is attempting to deploy a commit to the NextUI Inc Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughThe pull request includes updates to the documentation for the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🔇 Additional comments (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Hello, I saw you approved the changes but it seems like no any changes in the document. Might I do something? This is my first pull request, sorry |
@Choneas Being approved doesn't mean release. |
📝 Description
Hello. In the code section of the Dynamic items subsection of the documentation for the Selector component, I found that the highlighted line is highlighted incorrectly, see the image for more details
⛳️ Current behavior (updates)
Incorrectly highlighted line
🚀 New behavior
Changed the highlighted line
💣 Is this a breaking change (Yes/No): Yes
I've wasted a lot of time and made a lot of mistakes that I shouldn't have because I didn't notice this, and I don't expect anyone else to (and it's night time)
Summary by CodeRabbit
Select
component, enhancing clarity for "Dynamic items," "Disabled," "Required," "Sizes," and "Label Placements."