Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(input): prevent clearable when input is readonly #3643

Merged
merged 7 commits into from
Sep 3, 2024
Merged

fix(input): prevent clearable when input is readonly #3643

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
faacd6b
fix(input): prevent clearable when input is readonly
ryxxn Aug 12, 2024
4ab1977
test(input): add tests for isReadOnly and isClearable interaction
ryxxn Aug 12, 2024
b06b079
chore(changeset): add changeset for fixing clear button visibility wi…
ryxxn Aug 12, 2024
3061744
fix(input): disable clear button from input is readonly
ryxxn Aug 13, 2024
b18408a
test(input): disable clear button when input is readonly
ryxxn Aug 13, 2024
125ab66
chore(changeset): update changeset
ryxxn Aug 13, 2024
87ae28b
chore(changeset): revise message
wingkwong Aug 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/components/input/src/use-input.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,7 @@ export function useInput<T extends HTMLInputElement | HTMLTextAreaElement = HTML
typeof props.errorMessage === "function"
? props.errorMessage({isInvalid, validationErrors, validationDetails})
: props.errorMessage || validationErrors?.join(" ");
const isClearable = !!onClear || originalProps.isClearable;
const isClearable = !originalProps.isReadOnly && (!!onClear || originalProps.isClearable);
const hasElements = !!label || !!description || !!errorMessage;
const hasPlaceholder = !!props.placeholder;
const hasLabel = !!label;
Expand Down