Rename nextclade2 to nextclade #969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: #968 Sister PRs: - nextstrain/docker-base#60 - nextstrain/mpox#91
This was referenced Jun 29, 2022
victorlin
requested changes
Jun 29, 2022
victorlin
approved these changes
Jun 30, 2022
There was a problem hiding this comment.
CI test build is failing since nextstrain/docker-base#60 hasn't been merged yet – same comment as nextstrain/docker-base#60 (review)
huddlej
approved these changes
Jul 1, 2022
There was a problem hiding this comment.
This worked with the latest Docker image and with the latest Conda environment (via --use-conda). Merging now, but we should also update the change log and tags to note a new version as of the change to nextclade2, since this was a breaking change.
EDIT: Version release PR is #971
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #968
Sister PRs: