Include distances and explicit aa muts by default #630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huddlej
force-pushed
the
remove-use-nextalign
branch
from
f7ff571 to
967a081
Compare
We used to only include these annotations in auspice JSONs when `use_nextalign` was set to `true`. Now that nextalign is the default (and only) aligner, we should always include these annotations and allow users who never enabled nextalign to benefit from them.
huddlej
force-pushed
the
remove-use-nextalign
branch
from
967a081 to
165fe31
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
We used to only include these annotations in auspice JSONs when
use_nextalignwas set totrue. Now that nextalign is the default (and only) aligner, we should always include these annotations and allow users who never enabled nextalign to benefit from them.Related issue(s)
Related to #615
Testing
What steps should be taken to test the changes you've proposed?
If you added or changed behavior in the codebase, did you update the tests, or do you need help with this?
Release checklist
If this pull request introduces new features, complete the following steps:
docs/change_log.mdin this pull request to document these changes by the date they were added.