Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add weighted sampling docs #223

Merged
merged 5 commits into from
Aug 22, 2024
Merged

Conversation

victorlin
Copy link
Member

@victorlin victorlin commented Aug 16, 2024

preview

Description of proposed changes

Adding docs for nextstrain/augur#1318

Checklist

@victorlin victorlin self-assigned this Aug 16, 2024
@victorlin victorlin force-pushed the victorlin/add-weighted-sampling-docs branch from 872bddc to 2c06854 Compare August 19, 2024 19:38
@victorlin victorlin force-pushed the victorlin/update-subsampling-docs branch from 5962ddb to 65f8fe4 Compare August 19, 2024 21:54
@victorlin victorlin force-pushed the victorlin/add-weighted-sampling-docs branch from 2c06854 to 522fe9c Compare August 19, 2024 22:01
@victorlin victorlin force-pushed the victorlin/update-subsampling-docs branch from 65f8fe4 to b5cb803 Compare August 19, 2024 22:57
@victorlin victorlin force-pushed the victorlin/add-weighted-sampling-docs branch from 522fe9c to 17ca960 Compare August 19, 2024 22:57
@victorlin victorlin force-pushed the victorlin/update-subsampling-docs branch 3 times, most recently from 62e01e5 to 5779a70 Compare August 20, 2024 23:35
Base automatically changed from victorlin/update-subsampling-docs to master August 20, 2024 23:36
I plan to use actual values in subsequent examples. Region gets the
point across in a more politically neutral way.
@victorlin victorlin force-pushed the victorlin/add-weighted-sampling-docs branch from 17ca960 to 76ff695 Compare August 20, 2024 23:40
Probabilistic sampling is really a special case of uniform sampling, not
a separate sampling method. Make it a section under caveats.
This makes it easier to add a section on weighted sampling, which also
falls under grouped sampling and shares the same caveats as uniform
sampling.
Add a new section and adjust existing content accordingly.
Weighted sampling makes this scenario technically feasible, but
practically difficult to achieve in a single augur filter call. Explain
this trade-off in detail.
@victorlin victorlin force-pushed the victorlin/add-weighted-sampling-docs branch from f4443a5 to c6084f3 Compare August 21, 2024 22:02
@victorlin victorlin marked this pull request as ready for review August 21, 2024 22:05
@victorlin victorlin merged commit 21e038d into master Aug 22, 2024
4 checks passed
@victorlin victorlin deleted the victorlin/add-weighted-sampling-docs branch August 22, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants