fix(styles): navigation progress buttons to not align properly on IE #875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes navigation progress buttons to not align properly in flexbox container when browsing using Internet Explorer (any version). This is a browser bug, so called "flexbug-15" as described in: https://github.com/philipwalton/flexbugs#flexbug-15 I applied the workaround as described there. Originally reported by @emmahodcroft at: #655
|
I also submitted same fix for the master branch anyways: #876 |
kairstenfay
force-pushed
the
narrative-mobile
branch
from
9760833 to
b2b0015
Compare
|
Thanks for submitting this, @ivan-aksamentov! This resolves #655. |
kairstenfay
approved these changes
Jan 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@kairstenfay
Hi Kairsten,
Pardon me for this blatant intrusion into your private branch.
I was playing with IE fixes today and noticed that one of the styling bugs is much easier to fix on your branch (compared to master). It probably will be merged soon(ish) anyway, right? So I decided to base my fix here, rather that dealing with master, which has the component in question in a bit of a hairy state.
Anyways, this commit fixes navigation progress buttons to not align properly in flexbox container when browsing using Internet Explorer (any version).
This is, what I believe to be a browser bug, so called "flexbug-15" as described in:
https://github.com/philipwalton/flexbugs#flexbug-15
I applied the workaround as described there.
Originally reported by @emmahodcroft at: #655
There are still styling issues in IE, but at least working navigation makes narrative usable for these folks who still use IE.
Before:
After:
Do you think you can merge these changes along with yours?