Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always show internal node name in shift-click modal #1847

Closed
jameshadfield opened this issue Sep 5, 2024 · 0 comments · Fixed by #1849
Closed

Always show internal node name in shift-click modal #1847

jameshadfield opened this issue Sep 5, 2024 · 0 comments · Fixed by #1849
Labels
bug Something isn't working

Comments

@jameshadfield
Copy link
Member

jameshadfield commented Sep 5, 2024 •
edited by corneliusroemer
Loading

Shift-clicking on internal nodes (branches) should always show the node name (typically in the form of NODE_0000123). Currently this functionality is removed iff the tip label is "Sample Name". Introduced in #1668, specifically related to this conversation.

Broken (when tip label is "Sample Name"):

image

Correct (when tip label is anything else):

image
@jameshadfield jameshadfield added the bug Something isn't working label Sep 5, 2024
jameshadfield added a commit that referenced this issue Sep 10, 2024
@jameshadfield
Always show internal node name in branch modal
04a5052 
This fixes a bug introduced in #1668 where the node name wouldn't be
shown when the selected tip label is "Sample Name".

Closes #1847
@jameshadfield jameshadfield mentioned this issue Sep 10, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Always show internal node name in branch modal nextstrain/auspice
1 participant
@jameshadfield