Sidebar filtering options should include all node/branch attrs #1251
Comments
|
With the work to export metadata fields without defining them as coloring options (nextstrain/augur#1384), we should extend filtering options to include all available metadata fields. EDIT: Relevant section of the code also include TODO comment to include all traits auspice/src/actions/recomputeReduxState.js Lines 227 to 234 in 40befc6 |
|
I think this issue comment was written simultaneously with Jover's comment above. I think this issue should be extended a bit (but I'm including here as it'll almost certainly be simpler to do it in a single push). I think all node and branch attrs defined across a tree should be searchable via the dropdown sidebar. That is, the |
joverlee521
changed the title
The sidebar filtering now surfaces all valid node-attrs defined across
the (terminal) nodes. URL queries (`?f_${attrName}=value1,value2,...`)
also work for all known attrs. Attributes which are known to be
continuous (via a colorings definition) are excluded, as the filtering
UI is not (yet) able to handle these; if a non-coloring continuous
attribute is set on the nodes then this will end up as a multitude of
numerical options in the sidebar.
As part of this implementation we have removed `stateCountAttrs` from
redux state and improved the validation of (filtering) URL queries.
The behaviour of filtering, and the restriction to collecting attributes
from terminal nodes only, is unchanged. See #1275 for more context.
Closes #1251
The sidebar filtering now surfaces all valid node-attrs defined across
the (terminal) nodes. URL queries (`?f_${attrName}=value1,value2,...`)
also work for all known attrs. Attributes which are known to be
continuous (via a colorings definition) are excluded, as the filtering
UI is not (yet) able to handle these; if a non-coloring continuous
attribute is set on the nodes then this will end up as a multitude of
numerical options in the sidebar.
As part of this implementation we have removed `stateCountAttrs` from
redux state and improved the validation of (filtering) URL queries.
The behaviour of filtering, and the restriction to collecting attributes
from terminal nodes only, is unchanged. See #1275 for more context.
Closes #1251
The sidebar filtering now surfaces all valid node-attrs defined across
the (terminal) nodes. URL queries (`?f_${attrName}=value1,value2,...`)
also work for all known attrs. Attributes which are known to be
continuous (via a colorings definition) are excluded, as the filtering
UI is not (yet) able to handle these; if a non-coloring continuous
attribute is set on the nodes then this will end up as a multitude of
numerical options in the sidebar.
As part of this implementation we have removed `stateCountAttrs` from
redux state and improved the validation of (filtering) URL queries.
The behaviour of filtering, and the restriction to collecting attributes
from terminal nodes only, is unchanged. See #1275 for more context.
Closes #1251
The original intent of the sidebar filtering was to allow filtering by all traits which are defined via
metadata.filtersas well as those defined viametadata.colorings. The latter has not yet been implemented.Note that the filters which appear in the footer of Auspice should still only reflect those defined in
metadata.filters.The text was updated successfully, but these errors were encountered: