Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

io: Split io.py into smaller files under new io/ #949

Merged
merged 2 commits into from
Jun 15, 2022

Conversation

victorlin
Copy link
Member

Description of proposed changes

This change helps modularize the functions within io.py and io_support/. With the wildcard imports in io/__init__.py, existing imports do not have to be modified.

Related issue(s)

N/A

Testing

Test files updated to reflect the new way of organizing things. Note that there is no test_metadata.py or test_print.py but the contents already have full coverage based on the Codecov report.

This change helps modularize the functions within io.py and io_support/. With the wildcard imports in io/__init__.py, existing imports do not have to be modified.

Test files updated to reflect the new way of organizing things. Note that there is no test_metadata.py or test_print.py but the contents already have full coverage based on the Codecov report.
Built-in open is sufficient. Avoids an extra import of an internal function which is already tested elsewhere.
@victorlin victorlin requested a review from a team May 25, 2022 00:20
@victorlin victorlin self-assigned this May 25, 2022
@codecov
Copy link

codecov bot commented May 25, 2022

Codecov Report

Merging #949 (b31b9bc) into master (5916362) will increase coverage by 0.02%.
The diff coverage is 63.77%.

@@            Coverage Diff             @@
##           master     #949      +/-   ##
==========================================
+ Coverage   59.34%   59.36%   +0.02%     
==========================================
  Files          42       47       +5     
  Lines        6011     6014       +3     
  Branches     1539     1539              
==========================================
+ Hits         3567     3570       +3     
  Misses       2185     2185              
  Partials      259      259              
Impacted Files Coverage Δ
augur/io/vcf.py 42.50% <42.50%> (ø)
augur/io/__init__.py 100.00% <100.00%> (ø)
augur/io/file.py 100.00% <100.00%> (ø)
augur/io/metadata.py 100.00% <100.00%> (ø)
augur/io/print.py 100.00% <100.00%> (ø)
augur/io/sequences.py 100.00% <100.00%> (ø)
augur/io/shell_command_runner.py 91.89% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5916362...b31b9bc. Read the comment docs.

Copy link
Member

@tsibley tsibley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! Definitely appreciate this direction and removal of the augur.io_support package in favor of modules under augur.io.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

2 participants