Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

io: Migrate VCF functions from filter+utils to io #929

Merged
merged 3 commits into from
May 24, 2022

Conversation

victorlin
Copy link
Member

@victorlin victorlin commented May 17, 2022

Description of proposed changes

See commit messages.

Motivated by work in #854.

Related issue(s)

N/A

Testing

Tests moved accordingly.

@victorlin victorlin requested a review from a team May 17, 2022 04:36
@victorlin victorlin self-assigned this May 17, 2022
@codecov
Copy link

codecov bot commented May 17, 2022

Codecov Report

Merging #929 (4279b66) into master (9dda176) will increase coverage by 0.02%.
The diff coverage is 50.53%.

@@            Coverage Diff             @@
##           master     #929      +/-   ##
==========================================
+ Coverage   59.59%   59.61%   +0.02%     
==========================================
  Files          43       43              
  Lines        6056     6059       +3     
  Branches     1550     1550              
==========================================
+ Hits         3609     3612       +3     
  Misses       2188     2188              
  Partials      259      259              
Impacted Files Coverage Δ
augur/io_support/shell_command_runner.py 91.66% <ø> (ø)
augur/utils.py 65.10% <ø> (+8.20%) ⬆️
augur/io.py 62.60% <43.90%> (-37.40%) ⬇️
augur/align.py 89.04% <100.00%> (+0.05%) ⬆️
augur/filter.py 96.19% <100.00%> (-0.13%) ⬇️
augur/index.py 87.50% <100.00%> (-0.18%) ⬇️
augur/mask.py 100.00% <100.00%> (ø)
augur/translate.py 38.18% <100.00%> (+0.24%) ⬆️
augur/tree.py 51.10% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9dda176...4279b66. Read the comment docs.

Copy link
Contributor

@huddlej huddlej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call. These functions always felt odd to have in filter.py. Since we are moving these functions, I'd slightly prefer to move then into io.py, to keep them close to other I/O logic.

These functions don't have filtering logic and can be moved next to the existing read_vcf() as a more appropriate scope.
These VCF functions are specifically IO-related utilities, so moving them to a better scope.
@victorlin victorlin changed the title filter: Move VCF functions to utils io: Migrate VCF functions from filter+utils to io May 24, 2022
@victorlin
Copy link
Member Author

@huddlej done: 4279b66. io.py is getting a little hairy – I have other changes I'd like to make but will put those in another PR.

@victorlin victorlin requested a review from huddlej May 24, 2022 18:47
@victorlin victorlin merged commit 787ae26 into nextstrain:master May 24, 2022
@victorlin victorlin deleted the filter/move-vcf-functions branch May 24, 2022 20:45
@victorlin victorlin added this to the Major release 16.0.0 milestone Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

2 participants