-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove utils.myopen()
, add tests for io.open_file()
#926
Conversation
Codecov Report
@@ Coverage Diff @@
## master #926 +/- ##
===========================================
+ Coverage 34.59% 59.59% +24.99%
===========================================
Files 42 43 +1
Lines 6044 6056 +12
Branches 1549 1550 +1
===========================================
+ Hits 2091 3609 +1518
+ Misses 3879 2188 -1691
- Partials 74 259 +185
Continue to review full report at Codecov.
|
d02db26
to
1cf0e9e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoa...I didn't realize this function was still in use! It looks like the only usage is now in the titer_model.py
module. Instead of maintaining myopen
, I would replace the reference to it in titer_model.py
with io.open_file
and then delete the function from utils.py
.
That open_file
function is already tested, so we wouldn't need to add any more tests as part of this change.
myopen is deprecated in favor of the newer function, already used by other modules.
1cf0e9e
to
785b232
Compare
utils.myopen()
, add tests for io.open_file()
@huddlej thanks for providing that context, I didn't realize |
Description of proposed changes
Motivated by work in #854.
Related issue(s)
N/A
Testing
Added tests for
io.open_file()
.