Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parse: Prefer strain over name as sequence ID field #1629

Merged
merged 5 commits into from
Sep 17, 2024

Conversation

victorlin
Copy link
Member

@victorlin victorlin commented Sep 10, 2024

Description of proposed changes

Following through with deprecation.

Related issue(s)

Checklist

  • Automated checks pass
  • Check if you need to add a changelog message
  • Check if you need to add tests
  • Check if you need to update docs

@victorlin victorlin added the breaking Makes a backwards incompatible change and should wait for major release label Sep 10, 2024
@victorlin victorlin self-assigned this Sep 10, 2024
The only usage of this function supplies all paramters, so any defaults
here are unused and are either duplicate or inaccurate.
@victorlin victorlin force-pushed the victorlin/parse-reorder-id-columns branch from 95d43df to 2ef8de8 Compare September 10, 2024 22:14
@victorlin victorlin force-pushed the victorlin/parse-reorder-id-columns branch from 2ef8de8 to 5e0bc54 Compare September 11, 2024 23:14
Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.06%. Comparing base (db54927) to head (5e0bc54).
Report is 13 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1629   +/-   ##
=======================================
  Coverage   71.06%   71.06%           
=======================================
  Files          79       79           
  Lines        8268     8268           
  Branches     2010     2009    -1     
=======================================
  Hits         5876     5876           
  Misses       2101     2101           
  Partials      291      291           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@victorlin victorlin marked this pull request as ready for review September 11, 2024 23:31
@tsibley tsibley merged commit 3de75cd into master Sep 17, 2024
28 checks passed
@tsibley tsibley deleted the victorlin/parse-reorder-id-columns branch September 17, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Makes a backwards incompatible change and should wait for major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants