Fix sorting of human-readable values within the html report summary table #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…able, Also refactor naming of variables and rounding of core usage factor Signed-off-by: Till Englert <till.englert96@gmail.com>
tillenglert
force-pushed
the
Report_Table_fix_sorting
branch
from
0247bc6 to
951c9e1
Compare
Signed-off-by: Till Englert <till.englert96@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves #26 . The issue was the parsing of values when sorting is requested. Also I refactored the variable names within the table and added a rounding function (only in human-readable table) for the core usage factor.