Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Properly handle image files #140

Merged
merged 2 commits into from
Sep 12, 2024
Merged

fix: Properly handle image files #140

merged 2 commits into from
Sep 12, 2024

Conversation

juliushaertl
Copy link
Member

@juliushaertl juliushaertl commented Sep 11, 2024

Fix #56

So far the basics are working but requires some cleanup and edge case handling

  • Basic fetching of images through websocket
  • Push new images to websocket
  • Read images from file content
  • Store images in memory and persist them on write
  • Properly cleanup images that are removed
  • Make sure that only updated data is transferred
  • Cleanup code

Signed-off-by: Julius Knorr <jus@bitgrid.net>
Signed-off-by: Julius Knorr <jus@bitgrid.net>
@juliushaertl
Copy link
Member Author

This is ready for review and some testing from my side. There might still be some room to optimize further but this should be good enough as a first approach to get images working.

@hweihwang Could you give it a try as well? Would be great to get some feedback on the implementation from you :)

@juliushaertl juliushaertl added bug Something isn't working 3. to review labels Sep 11, 2024
@juliushaertl juliushaertl mentioned this pull request Sep 12, 2024
2 tasks
@juliushaertl juliushaertl merged commit db7c0f9 into main Sep 12, 2024
24 checks passed
@juliushaertl juliushaertl deleted the fix/file-handling branch September 12, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uploaded images are not shared/stored
2 participants