Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Run cypress tests properly again on CI #2416

Merged
merged 2 commits into from
Aug 13, 2024
Merged

ci: Run cypress tests properly again on CI #2416

merged 2 commits into from
Aug 13, 2024

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Aug 13, 2024

Otherwise all runners pass with an empty spec

cypress-split: chunk NaN of 8
cypress-split: no specs to run, running an empty spec file /tmp/empty-NaN-of-8.cy.js

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr requested review from skjnldsv and susnux August 13, 2024 07:30
@juliusknorr juliusknorr marked this pull request as ready for review August 13, 2024 07:31
@juliusknorr juliusknorr added bug Something isn't working 3. to review Waiting for reviews labels Aug 13, 2024
@juliusknorr juliusknorr added this to the Nextcloud 30 milestone Aug 13, 2024
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
Copy link
Member Author

Will merge, remaining failures seem to be further regressions where I proposed a fix in #2417

@juliusknorr juliusknorr merged commit 8f152fb into master Aug 13, 2024
26 of 29 checks passed
@juliusknorr juliusknorr deleted the fix/cypress branch August 13, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants