Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable28] fix: Disable view file in trashbin #2094

Merged
merged 2 commits into from
Dec 7, 2023

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Dec 5, 2023

Backport #2093

@Pytal Pytal added the 3. to review Waiting for reviews label Dec 5, 2023
@Pytal Pytal added this to the Nextcloud 28 milestone Dec 5, 2023
@Pytal Pytal self-assigned this Dec 5, 2023
@Pytal

This comment was marked as resolved.

skjnldsv

This comment was marked as resolved.

Signed-off-by: Christopher Ng <chrng8@gmail.com>
(cherry picked from commit d3dfb79)
@Pytal

This comment was marked as resolved.

@Pytal
Copy link
Member Author

Pytal commented Dec 6, 2023

/compile /

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@skjnldsv skjnldsv merged commit d74811d into stable28 Dec 7, 2023
25 of 26 checks passed
@skjnldsv skjnldsv deleted the backport/stable28/2093 branch December 7, 2023 08:48
@skjnldsv skjnldsv added the bug Something isn't working label Dec 7, 2023
@blizzz
Copy link
Member

blizzz commented Dec 8, 2023

can we have a backport for 27?

@Pytal
Copy link
Member Author

Pytal commented Dec 8, 2023

can we have a backport for 27?

The new FileAction API was only in for 28 #1878 so this fix is not applicable and the issue did not reproduce on stable27

@blizzz
Copy link
Member

blizzz commented Dec 11, 2023

Okay, then no backporting, but the issue itself was reported against 27 and also reproduced, cf. nextcloud/server#40936 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants