feat: Allow comparing images, videos, audio #1862
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blizzz
added
3. to review
Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliusknorr
force-pushed
the
enh/compare-all-files
branch
from
b86e829 to
0a49829
Compare
juliusknorr
commented
Dec 28, 2023
| @@ -685,7 +687,7 @@ export default { | |||
|
|
|||
| // store current position | |||
| this.currentIndex = this.fileList.findIndex(file => file.basename === fileInfo.basename) | |||
| } else if (group && this.el === null) { | |||
| } else if (group && this.el === null && false) { | |||
There was a problem hiding this comment.
Need to find a more sane way to not fail on loading the file list for versions
juliusknorr
commented
Dec 28, 2023
| &--split { | ||
| .viewer__file--active { | ||
| .viewer__content--component { |
There was a problem hiding this comment.
Probably need to address #1588 to have clean styles for apps like pdfviewer and richdocuments to work with this.
This was referenced Mar 12, 2024
|
I lack time to finish this, will close for now |
Maybe #2395 would make it work straight away ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested during feature review
It might not be likely that those have versions but is still nice to at least offer it.