Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use proper alt text for viewer app modal #1651

Merged
merged 1 commit into from
May 11, 2023

Conversation

nfebe
Copy link
Contributor

@nfebe nfebe commented May 10, 2023

Alt text should contain readable text without encodings and other string markers such as "Content of".

Resolves : nextcloud/photos#1663

@nfebe nfebe requested a review from skjnldsv May 10, 2023 11:36
@skjnldsv
Copy link
Member

/backport to stable26

@skjnldsv
Copy link
Member

/backport to stable25

@backportbot-nextcloud backportbot-nextcloud bot added the backport-request Pending backport by the backport-bot label May 11, 2023
@skjnldsv skjnldsv added bug Something isn't working 4. to release Ready to be released and/or waiting for tests to finish accessibility labels May 11, 2023
@skjnldsv skjnldsv added this to the Nextcloud 27 milestone May 11, 2023
@skjnldsv
Copy link
Member

/compile amend /

@nextcloud-command nextcloud-command force-pushed the fix/1663/proper-alt-txt-accessibility branch from 29a3538 to 2373bc2 Compare May 11, 2023 06:22
Alt text should contain readable text without encodings
and other string markers such as "Content of".

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@skjnldsv skjnldsv force-pushed the fix/1663/proper-alt-txt-accessibility branch from 2373bc2 to b4ebae5 Compare May 11, 2023 06:25
@skjnldsv skjnldsv merged commit e724113 into master May 11, 2023
@skjnldsv skjnldsv deleted the fix/1663/proper-alt-txt-accessibility branch May 11, 2023 06:43
@backportbot-nextcloud backportbot-nextcloud bot removed the backport-request Pending backport by the backport-bot label May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish accessibility bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BITV] 9.1.1.1b/4.1 - Magnifed images have cumbersome and partly misleading alternative texts (1)
2 participants