Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update @nextcloud/vue to 6.0.0 #1319

Merged
merged 9 commits into from
Aug 23, 2022
Merged

Update @nextcloud/vue to 6.0.0 #1319

merged 9 commits into from
Aug 23, 2022

Conversation

juliushaertl
Copy link
Member

@juliushaertl juliushaertl commented Aug 11, 2022 •
edited
Loading

@juliushaertl juliushaertl mentioned this pull request Aug 11, 2022
Merged
Base automatically changed from dependabot/npm_and_yarn/vue-2.7.8 to master August 11, 2022 11:02
@juliushaertl
Copy link
Member Author

/compile amend /

@juliushaertl juliushaertl force-pushed the dependencies/nextcloud-vue6 branch 3 times, most recently from 97eb4ef to 728881a Compare August 12, 2022 10:39
skjnldsv
skjnldsv reviewed Aug 18, 2022
View reviewed changes
src/views/Viewer.vue
@@ -900,6 +906,17 @@ export default {
}
}

&.theme--dark::v-deep .button-vue--vue-tertiary {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be able to enforce the theme used more beautifully with css variables now
As well with the data-theme attribute @juliushaertl

@skjnldsv skjnldsv added the 2. developing Work in progress label Aug 18, 2022
@skjnldsv skjnldsv self-assigned this Aug 18, 2022
@skjnldsv skjnldsv added this to the Nextcloud 25 milestone Aug 18, 2022
@skjnldsv skjnldsv changed the title Update @nextcloud/vue to 6.0.0-beta.1 Update @nextcloud/vue to 6.0.0 Aug 18, 2022
@skjnldsv
Copy link
Member

skjnldsv commented Aug 18, 2022 •
edited
Loading

@juliushaertl do you know how we can adjust that here? Also the editor popups/modals
image
Getting the dom elements might be tricky as they come and go on the editor menu open/close 😕

@juliushaertl
Copy link
Member Author

Popovers like the ones from actions should be handled separately anyways by their own focus trap. Maybe you can share what the SfxModal-Wrapper does and how it gets initialised?

@skjnldsv
Copy link
Member

Popovers like the ones from actions should be handled separately anyways by their own focus trap. Maybe you can share what the SfxModal-Wrapper does and how it gets initialised?

External liv, this is either the SaveAs modal
image

Or the menus like this
image

@skjnldsv skjnldsv mentioned this pull request Aug 19, 2022
Merged
@juliushaertl
Copy link
Member Author

Is there any way you could trigger a callback on showing/hiding those? I assume they are handled fully by the image editor library :/

@skjnldsv
Copy link
Member

I assume they are handled fully by the image editor library :/

Yep!
I'll double check. But we might have to fix the focus trap

@vinicius73 vinicius73 mentioned this pull request Aug 23, 2022
Closed
2 tasks
@skjnldsv
Copy link
Member

Is there any way you could trigger a callback on showing/hiding those? I assume they are handled fully by the image editor library :/

Fixed, not super fond, but works™

@juliushaertl @skjnldsv
Bump @nextcloud/vue to 6.0.0-beta.1
9dee4d9 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliushaertl @skjnldsv
Show close button in the usual position
641de95 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliushaertl @skjnldsv
Overwrite focus/hover styles as we use the button on a dark backgorund
9a83744 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliushaertl @skjnldsv
Bump @nextcloud/vue to 6.0.0-beta.2
365cdde 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliushaertl @skjnldsv
Adjust cypress tests to match next/prev buttons
49a7db1 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliushaertl and others added 3 commits August 23, 2022 17:35
@juliushaertl @skjnldsv
Pass the sidebar as additional focus trap element
438dac6 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@skjnldsv
Bump @nextcloud/vue to beta 3
c6774a6 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv
Fix image editor modal trap
86860c0 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress labels Aug 23, 2022
@skjnldsv skjnldsv added the dependencies Pull requests that update a dependency file label Aug 23, 2022
@skjnldsv
Bump @nextcloud/vue to beta 4
9320acb 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv skjnldsv merged commit 1aa8f17 into master Aug 23, 2022
@skjnldsv skjnldsv deleted the dependencies/nextcloud-vue6 branch August 23, 2022 16:16
@blizzz blizzz mentioned this pull request Aug 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

Assignees

@skjnldsv skjnldsv

Labels
4. to release Ready to be released and/or waiting for tests to finish dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
Nextcloud 25
Development

Successfully merging this pull request may close these issues.
2 participants
@juliushaertl @skjnldsv