Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version name can't be set via fullscreen+sidebar #2390

Closed
AndyScherzinger opened this issue Jul 9, 2024 · 1 comment · Fixed by nextcloud/server#47407
Closed

Version name can't be set via fullscreen+sidebar #2390

AndyScherzinger opened this issue Jul 9, 2024 · 1 comment · Fixed by nextcloud/server#47407
Assignees
@susnux
Labels
1. to develop Accepted and waiting to be taken care of bug Something isn't working

Comments

@AndyScherzinger
Copy link
Member

Describe the bug
no_version_name_focusable

Can't get the cursor into the text field

Expected behavior
being able to set a version name

Screenshots
see above

Desktop (please complete the following information):

  • OS: [e.g. iOS] Win11Pro
  • Browser [e.g. chrome, safari] FF
  • Version [e.g. 22] 127.0.2

Browser log

Open your console, reload your page and/or do the action leading to this issue and copy/paste the log in this thread.
How to access your browser console (Click to expand)

Chrome

  • Press either CTRL + SHIFT + J to open the “console” tab of the Developer Tools.
  • Alternative method:
    1. Press either CTRL + SHIFT + I or F12 to open the Developer Tools.
    2. Click the “console” tab.

Safari

  • Press CMD + ALT + I to open the Web Inspector.
  • See Chrome’s step 2. (Chrome and Safari have pretty much identical dev tools.)

IE9

  1. Press F12 to open the developer tools.
  2. Click the “console” tab.

Firefox

  • Press CTRL + SHIFT + K to open the Web console (COMMAND + SHIFT + K on Macs).
  • or, if Firebug is installed (recommended):
    1. Press F12 to open Firebug.
    2. Click on the “console” tab.

Opera

  1. Press CTRL + SHIFT + I to open Dragonfly.
  2. Click on the “console” tab.

Additional context
Add any other context about the problem here.
@AndyScherzinger AndyScherzinger added bug Something isn't working 0. Needs triage Pending approval or rejection. This issue is pending approval. labels Jul 9, 2024
@joshtrichards joshtrichards transferred this issue from nextcloud/photos Aug 5, 2024
@joshtrichards joshtrichards added 1. to develop Accepted and waiting to be taken care of and removed 0. Needs triage Pending approval or rejection. This issue is pending approval. labels Aug 5, 2024
@skjnldsv
Copy link
Member

skjnldsv commented Aug 6, 2024

Versions is a server issue @joshtrichards :)

cc @artonge

susnux added a commit to nextcloud/server that referenced this issue Aug 21, 2024
@susnux
fix(files_versions): Migrate version name dialog from NcModal to NcDi…
72546ad 
…alog

* Resolves nextcloud/viewer#2390

Make the version name dialog a real dialog instead of a modal.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux mentioned this issue Aug 21, 2024
Merged
4 tasks
@susnux susnux self-assigned this Aug 21, 2024
susnux added a commit to nextcloud/server that referenced this issue Aug 22, 2024
@susnux
fix(files_versions): Migrate version name dialog from NcModal to NcDi…
0f97593 
…alog

* Resolves nextcloud/viewer#2390

Make the version name dialog a real dialog instead of a modal.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@github-project-automation github-project-automation bot moved this from 👓 Design review to 🎉 Done in 🖍 Design team Aug 22, 2024
backportbot bot pushed a commit to nextcloud/server that referenced this issue Aug 22, 2024
@susnux @backportbot
fix(files_versions): Migrate version name dialog from NcModal to NcDi…
27bca48 
…alog

* Resolves nextcloud/viewer#2390

Make the version name dialog a real dialog instead of a modal.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux added a commit to nextcloud/server that referenced this issue Aug 28, 2024
@susnux
fix(files_versions): Migrate version name dialog from NcModal to NcDi…
dc5f67d 
…alog

* Resolves nextcloud/viewer#2390

Make the version name dialog a real dialog instead of a modal.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
nextcloud-command pushed a commit to nextcloud/server that referenced this issue Aug 28, 2024
@susnux @nextcloud-command
fix(files_versions): Migrate version name dialog from NcModal to NcDi…
ee522cc 
…alog

* Resolves nextcloud/viewer#2390

Make the version name dialog a real dialog instead of a modal.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
AndyScherzinger pushed a commit to nextcloud/server that referenced this issue Aug 28, 2024
@susnux @AndyScherzinger
fix(files_versions): Migrate version name dialog from NcModal to NcDi…
ffefa21 
…alog

* Resolves nextcloud/viewer#2390

Make the version name dialog a real dialog instead of a modal.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@susnux susnux

Labels
1. to develop Accepted and waiting to be taken care of bug Something isn't working
Projects
🖍 Design team
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(files_versions): Migrate version name dialog from NcModal to NcDialog nextcloud/server
4 participants
@AndyScherzinger @joshtrichards @susnux @skjnldsv