Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User migration foundation #5

Merged
merged 25 commits into from
Feb 3, 2022
Merged

User migration foundation #5

merged 25 commits into from
Feb 3, 2022

Conversation

come-nc
Copy link
Collaborator

@come-nc come-nc commented Jan 13, 2022

Signed-off-by: Côme Chilliet come.chilliet@nextcloud.com

@come-nc come-nc force-pushed the enhancement/user-migration-foundation branch from 9749ee2 to 7a8cda8 Compare January 18, 2022 15:48
@come-nc come-nc force-pushed the enhancement/user-migration-foundation branch from 06da051 to 163eb9e Compare January 27, 2022 11:14
@come-nc come-nc self-assigned this Jan 27, 2022
@come-nc come-nc requested a review from Pytal January 27, 2022 13:03
@come-nc come-nc mentioned this pull request Jan 27, 2022
Open
19 tasks
@Pytal Pytal force-pushed the enhancement/user-migration-foundation branch from 0997b30 to b0ab9be Compare January 28, 2022 23:59
@Pytal
Copy link
Member

Pytal commented Jan 29, 2022

Rebased after #24 merged to main to resolve failing PHP 7.3 CI

@Pytal Pytal force-pushed the enhancement/user-migration-foundation branch from 0241511 to d33eb02 Compare January 29, 2022 00:18
Pytal
Pytal approved these changes Jan 29, 2022
View reviewed changes
Copy link
Member

@Pytal Pytal left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid 👌, only the occ related stuff is used while the background job as well as the database related code is unused?

@Pytal Pytal requested review from a team, ArtificialOwl, icewind1991, blizzz, skjnldsv, nickvergessen and ChristophWurst and removed request for a team January 29, 2022 00:36
@nickvergessen nickvergessen removed their request for review January 29, 2022 05:59
@come-nc
Copy link
Collaborator Author

come-nc commented Jan 31, 2022

Solid ok_hand, only the occ related stuff is used while the background job as well as the database related code is unused?

Yes maybe we can remove this for now, as the occ commands do not use the background job. We will add the background job back if it’s used is some future development. I will remove them in a commit and we can use git history later to get them back.

icewind1991
icewind1991 requested changes Jan 31, 2022
View reviewed changes
lib/ExportDestination.php Outdated Show resolved Hide resolved
lib/IImportSource.php Outdated Show resolved Hide resolved
@come-nc come-nc requested a review from icewind1991 February 1, 2022 14:22
@come-nc come-nc force-pushed the enhancement/user-migration-foundation branch from 81b8774 to aa71570 Compare February 1, 2022 14:24
@come-nc
First draft of background job and command
870d9be 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
Make files copy in a files subfolder and also export account information
aabea81 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
Use our own Exception class
5759fb5 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
Pack the export in an archive
2b28010 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
Use OC\Archive to build the archive
f9780a5 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
Comment out archive and temp folder things for now
793cd30 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
Export versions and settings
e8609d8 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
come-nc and others added 16 commits February 3, 2022 09:48
@come-nc
Add basic user information, and nextcloud version
240b59d 
User export may be done another way later, for now storing basic
 information.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
Zip things together with ZipStreamer
90ffb87 
First POC of zipping

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
Add an IExportDestination interface to abstract away how the export is
a8ba325 
 actually stored/compressed

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
Add import features
130f94a 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
Fix file import
2229908 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
Use ITempManager instead of hardcoded /tmp
8aeca6b 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
Move the export to a destination folder provided on the command line
25510ed 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
Remove resolved TODOs and fill empty one
6c3f550 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
Rename classes related to both Export and Import
9758f69 
UserExport -> UserMigration

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
Fix codesniffer errors
07f976f 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@Pytal @come-nc
Remove unused navigation entry
f39d1a7 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal @come-nc
Fix naming of migration service
ce8a62b 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@come-nc
Fix variable typo in importAppsSettings
45862da 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
Remove background job for now
34540ee 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
Use the new getAllUserValues method to export user configuration
1e77b97 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
Use OCP\Files\Folder instead of View
c77ddac 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc come-nc force-pushed the enhancement/user-migration-foundation branch from aa71570 to c77ddac Compare February 3, 2022 08:49
@come-nc
Fixing psalm errors
c69a715 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
Fix last psalm errors and add the rest to the baseline
bbed42f 
The docblock of addFileFromStream in zipsteamer is wrong.
There are also errors about IRootFolder depending on OC\Hook\Emitter.
Ignoring those.
Using OC\Archive might be wrong since it is not in OCP, will look into
 that later.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc come-nc merged commit bae9cb4 into main Feb 3, 2022
@come-nc come-nc deleted the enhancement/user-migration-foundation branch February 3, 2022 10:32
@come-nc come-nc added this to the 0.1 milestone Apr 11, 2022
@pmarini-nc pmarini-nc mentioned this pull request May 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@icewind1991 icewind1991 icewind1991 approved these changes

@Pytal Pytal Pytal approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl

@blizzz blizzz Awaiting requested review from blizzz

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

Assignees

@come-nc come-nc

Labels
None yet
Projects
None yet
Milestone
1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@come-nc @Pytal @icewind1991