Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Update Directory #420

Merged
merged 8 commits into from
Sep 2, 2022
Merged

Introduce Update Directory #420

merged 8 commits into from
Sep 2, 2022

Conversation

solracsf
Copy link
Member

@solracsf solracsf commented Jun 30, 2022

Allow to use a specific directory as updater working directory.

This is 100% backwards compatible as, if not set (the default), fallback to default datadirectory

🆗 Done by nextcloud/server#33692


This serves 2 purposes:

  1. If datadirectory is set on a slow filesystems (like NFS) update can be very slow, or even time out. On our tests, gain is 500% less time on upgrade when moving away from NFS to Block, as working on very small files on network filesystems is a pain.
  2. Allow sysadmin to specify where noisy I/O can be placed. If updatedirectory is placed on the same disk where application resides, which is not always the same disk as datadirectory, "Move new files in place" step is an atomic operation.

Allow to specify a specific directory as updater working directory
@blizzz blizzz requested review from PVince81 and skjnldsv June 30, 2022 11:07
@blizzz blizzz added this to the Nextcloud 25 milestone Jun 30, 2022
Signed-off-by: Git'Fellow <carlos@reendex.com>
solracsf added a commit to nextcloud/server that referenced this pull request Aug 25, 2022
To be merged after nextcloud/updater#420

Signed-off-by: Git'Fellow <carlos@reendex.com>
solracsf and others added 4 commits August 25, 2022 12:56
Signed-off-by: Git'Fellow <carlos@reendex.com>
Signed-off-by: Git'Fellow <carlos@reendex.com>
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants