Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correctly set "new"-menu entry for folder description #6291

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Aug 30, 2024

📝 Summary

  1. The bug in uploader library was fixed so we should set in on the "Other" section
  2. The SVG must be imported with ?raw otherwise it does not correctly include it.

🖼️ Screenshots

🏚️ Before 🏡 After
image image

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation (README or documentation) has been updated or is not required

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux added bug Something isn't working design Experience, interaction, interface, … 3. to review labels Aug 30, 2024
@susnux susnux added this to the Nextcloud 31 milestone Aug 30, 2024
@susnux
Copy link
Contributor Author

susnux commented Aug 30, 2024

/backport to stable30

@susnux
Copy link
Contributor Author

susnux commented Aug 30, 2024

1) test if attachment folder is deleted after having deleted a markdown file

Seems to be unrelated, no?

@juliushaertl
Copy link
Member

Should, but haven't seen this failing in the past, restarted to check

@mejo-
Copy link
Member

mejo- commented Sep 4, 2024

The new failing cypress test also fails on other PRs, so unrelated. We have to look into this seperately.

@mejo- mejo- merged commit 135ab34 into main Sep 4, 2024
58 of 61 checks passed
@mejo- mejo- deleted the fix/add-folder-description branch September 4, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug Something isn't working design Experience, interaction, interface, …
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants