Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable29] fix(attachments): Don't require document session for getting attachments #5981

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Jul 2, 2024

Backport of #5979

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot backportbot bot requested review from juliushaertl and mejo- July 2, 2024 07:18
@backportbot backportbot bot added bug Something isn't working 3. to review labels Jul 2, 2024
@backportbot backportbot bot added this to the Nextcloud 29.0.4 milestone Jul 2, 2024
In editors with a user or share token we don't want to depend on a
document session for fetching attachments.

This fixes fetching attachments in editors without a document session
but with a user session or share token, e.g. in view mode of the
Collectives app.

Fixes: nextcloud/collectives#1201

Signed-off-by: Jonas <jonas@freesources.org>
@mejo- mejo- marked this pull request as ready for review July 2, 2024 08:27
@mejo- mejo- merged commit f8f3f7b into stable29 Jul 2, 2024
63 checks passed
@mejo- mejo- deleted the backport/5979/stable29 branch July 2, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant