Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Tables): require at least one cell in the header #5461

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

max-nextcloud
Copy link
Collaborator

📝 Summary

🖼️ Screenshots

🏚️ Before 🏡 After
grafik grafik

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • hard to test:
    • somewhat complicated to create the state
    • hard to detect it's actually broken.
  • Documentation is not required

@max-nextcloud
Copy link
Collaborator Author

/backport to stable28

@max-nextcloud
Copy link
Collaborator Author

/backport to stable27

@max-nextcloud
Copy link
Collaborator Author

/backport to stable26

@max-nextcloud
Copy link
Collaborator Author

max-nextcloud commented Mar 11, 2024

After this fix the broken tables below are removed when opening the session again.

Fixes #4793.

Signed-off-by: Max <max@nextcloud.com>
@max-nextcloud max-nextcloud merged commit 4206566 into main Mar 12, 2024
59 checks passed
@max-nextcloud max-nextcloud deleted the fix/images-in-tables branch March 12, 2024 15:46
Copy link

backportbot bot commented Mar 12, 2024

The backport to stable26 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable26
git pull origin stable26

# Create the new backport branch
git checkout -b backport/5461/stable26

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick f7d50b89

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/5461/stable26

Error: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Copy link

backportbot bot commented Mar 12, 2024

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27

# Create the new backport branch
git checkout -b backport/5461/stable27

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick f7d50b89

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/5461/stable27

Error: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken table state
3 participants