fix(deps): stick to @nextcloud/files v2 #5264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure if we should do that same for stable27. |
2 flaky tests on run #12435 ↗︎
Details:
|
||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Sync > saves the actual file and document state |
Screenshots
|
|
| Sync > saves on close |
Screenshots
|
|
Review all test suite changes for PR #5264 ↗︎
Signed-off-by: Max <max@nextcloud.com>
max-nextcloud
force-pushed
the
update/stable26-nextcloud-files-2
branch
from
d718678
to
7c53e3f
Compare
|
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
1 task
mejo-
approved these changes
Jan 15, 2024
|
/backport to stable27 |
|
The backport to stable27 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable27
git pull origin stable27
# Create the new backport branch
git checkout -b fix/foo-stable27
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27Error: Unknown error More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
|
/backport 7c53e3f to stable27 |
|
The backport to stable27 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable27
git pull origin stable27
# Create the new backport branch
git checkout -b fix/foo-stable27
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27Error: Unknown error More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
max-nextcloud
added a commit
that referenced
this pull request
Jan 15, 2024
* Forward ports: #5264 * Resolves: failing build in #5251 `@nextcloud/files` requires node 20 and npm 9. This dependency was introduced based on a beta version that did not have these requirements yet. Roll back to version 2 rather than updating the entire node stack. Only difference here is that `formatFileSize` which we use will default to non-binary file sizes - i.e 1.024KB instead of 1KiB as this only became available with v3: * https://github.com/nextcloud-libraries/nextcloud-files/pull/770/files#diff-237392127cb275fc6789cf6faec014d758950c87ccdab0329dde793d034190d8 Signed-off-by: Max <max@nextcloud.com>
juliushaertl
pushed a commit
that referenced
this pull request
Jan 15, 2024
* Forward ports: #5264 * Resolves: failing build in #5251 `@nextcloud/files` requires node 20 and npm 9. This dependency was introduced based on a beta version that did not have these requirements yet. Roll back to version 2 rather than updating the entire node stack. Only difference here is that `formatFileSize` which we use will default to non-binary file sizes - i.e 1.024KB instead of 1KiB as this only became available with v3: * https://github.com/nextcloud-libraries/nextcloud-files/pull/770/files#diff-237392127cb275fc6789cf6faec014d758950c87ccdab0329dde793d034190d8 Signed-off-by: Max <max@nextcloud.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
@nextcloud/filesrequires node 20 and npm 9. This dependency was introduced based on a beta version that did not have these requirements yet. Roll back to version 2 rather than updating the entire node stack.Only difference here is that
formatFileSizewhich we use will default to non-binary file sizes - i.e 1.024KB instead of 1KiB as this only became available with v3: