Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup(SyncService): this.sessions and this.steps #5188

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

max-nextcloud
Copy link
Collaborator

@max-nextcloud max-nextcloud commented Jan 2, 2024

📝 Summary

Both were kept up to date but never used as far as i can tell.

Extracted from #3799

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation is not needed

Both were kept up to date but never used as far as i can tell.

Signed-off-by: Max <max@nextcloud.com>
Copy link
Member

@juliushaertl juliushaertl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, also couldn't see any usage when double checking.

@juliushaertl juliushaertl merged commit 4707b75 into main Jan 2, 2024
37 checks passed
@juliushaertl juliushaertl deleted the cleanup/sync-service branch January 2, 2024 16:13
@juliushaertl juliushaertl added this to the Nextcloud 29 milestone Jan 2, 2024
@juliushaertl
Copy link
Member

@max-nextcloud Labels and milestone would be good to set. That way it is much easier to collect changes for either a changelog or aggregating what's new on releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants