Rework cypress commands #4364
Merged
Rework cypress commands #4364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliusknorr
force-pushed
the
ci/flaky-cypress
branch
4 times, most recently
from
1a6ea45 to
814d33b
Compare
mejo-
approved these changes
Jun 26, 2023
There was a problem hiding this comment.
Thanks a ton for looking into this @juliushaertl! All changes look good, just the first commit message seems to be wrong and a bit cluttered.
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
… requests are still being fired Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliusknorr
force-pushed
the
ci/flaky-cypress
branch
from
814d33b to
33372da
Compare
|
Cleaned up the commit messages :) |
This was referenced Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a set of changes to cypress commands that should increase stability over CI runs. There still seem to be rare failures where some requests return a 401 on the backend which I'm continuing to follow debugging in #4350 however I think this would already be good to get in fast: