Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: autofocus own rich workspaces only at freshly created #4119

Merged
merged 1 commit into from
May 5, 2023

Conversation

luka-nextcloud
Copy link
Contributor

📝 Summary

🖼️ Screenshots

🏚️ Before 🏡 After
B A

🚧 TODO

  • ...

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation (README or documentation) has been updated or is not required

@luka-nextcloud luka-nextcloud self-assigned this May 4, 2023
@cypress
Copy link

cypress bot commented May 4, 2023

1 failed and 1 flaky tests on run #9672 ↗︎

1 138 1 3 Flakiness 1

Details:

fix: autofocus own rich workspaces only at freshly created
Project: Text Commit: 395a26ae0d
Status: Failed Duration: 03:54 💡
Started: May 5, 2023 7:06 AM Ended: May 5, 2023 7:10 AM
Failed  cypress/e2e/nodes/FrontMatter.spec.js • 1 failed test

View Output Video

Test Artifacts
Front matter support > Open file with front matter Output Screenshots
Flakiness  cypress/e2e/sync.spec.js • 1 flaky test

View Output Video

Test Artifacts
Sync > recovers from a lost connection Output Screenshots

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

Copy link
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@juliusknorr juliusknorr force-pushed the feature/avoid-autofocus branch from 836ff76 to 4aac629 Compare May 4, 2023 09:29
@juliusknorr juliusknorr added bug Something isn't working 3. to review labels May 4, 2023
@juliusknorr juliusknorr added this to the Nextcloud 27 milestone May 4, 2023
@juliusknorr
Copy link
Member

/backport to stable26

@juliusknorr
Copy link
Member

/backport to stable25

@juliusknorr
Copy link
Member

/compile amend /

Signed-off-by: Luka Trovic <luka@nextcloud.com>
@juliusknorr juliusknorr force-pushed the feature/avoid-autofocus branch from 0c60ccc to 395a26a Compare May 5, 2023 07:02
@juliusknorr juliusknorr merged commit 88580a5 into main May 5, 2023
@delete-merged-branch delete-merged-branch bot deleted the feature/avoid-autofocus branch May 5, 2023 07:12
@backportbot-nextcloud
Copy link

The backport to stable25 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable25
git pull origin/stable25

# Create the new backport branch
git checkout -b fix/foo-stable25

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable25

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@juliusknorr
Copy link
Member

This is not an issue on 25 so we can skip the backport

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid autofocus if existing rich workspace is loaded
2 participants