[stable25] Fix hard line breaks displayed with additional new line between #3416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
To preserve softbreaks within md files we preserve all whitespaces, so we must not introduce additional new lines after `<br>` elements. Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
No additional new line should be added after hard line breaks, this is tested by a new tiptap test. Modified CommonMark rendering test to allow hard breaks without newline. Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
juliushaertl
requested review from
susnux,
a team,
julien-nc and
max-nextcloud
and removed request for
a team
|
Test summaryRun details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
||||||||||||||||||||||||||||||||||
|
/compile |
mejo-
previously approved these changes
Nov 11, 2022
Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
susnux
force-pushed
the
backport/3388/stable25
branch
from
8cf37f8
to
8128f96
Compare
|
The commonmark normalization was missing from the backport |
mejo-
approved these changes
Nov 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #3388