Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable25] Fix: table settings button #3118

Merged
merged 2 commits into from
Oct 5, 2022
Merged

[stable25] Fix: table settings button #3118

merged 2 commits into from
Oct 5, 2022

Conversation

backportbot-nextcloud[bot]
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented Oct 3, 2022 •
edited
Loading

  • ⚠️ This backport had conflicts and is incomplete

backport of #3074

@backportbot-nextcloud backportbot-nextcloud bot added bug Something isn't working design Experience, interaction, interface, … labels Oct 3, 2022
@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 25 milestone Oct 3, 2022
@vinicius73
Copy link
Member

/compile

@blizzz blizzz mentioned this pull request Oct 3, 2022
Merged
3 tasks
@blizzz
Copy link
Member

blizzz commented Oct 3, 2022

some CI is failing. Is this even ready for review?

@vinicius73
Copy link
Member

vinicius73 commented Oct 3, 2022 •
edited
Loading

some CI is failing. Is this even ready for review?

One of CI error is related to recent changes on server nextcloud/server#34331

The other is "flaky", we should turn it more efficient.

@blizzz
Copy link
Member

blizzz commented Oct 3, 2022

Ok, thanks for the clarification. Could you update the description and label?

@vinicius73
Copy link
Member

Waiting for nextcloud/server#34396 to merge it safely.

@blizzz
Copy link
Member

blizzz commented Oct 3, 2022

is merged

@mejo-
🐛 (#3069): fix table settings button
22084b3 
Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
@mejo-
Copy link
Member

mejo- commented Oct 5, 2022

/compile

@nextcloud-command
Compile assets
807e26e 
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
mejo-
mejo- approved these changes Oct 5, 2022
View reviewed changes
Copy link
Member

@mejo- mejo- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also good to be merged now.

@blizzz blizzz merged commit 3a7c62e into stable25 Oct 5, 2022
@delete-merged-branch delete-merged-branch bot deleted the backport/3074/stable25 branch October 5, 2022 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mejo- mejo- mejo- approved these changes

@julien-nc julien-nc Awaiting requested review from julien-nc

@juliushaertl juliushaertl Awaiting requested review from juliushaertl

@luka-nextcloud luka-nextcloud Awaiting requested review from luka-nextcloud

@max-nextcloud max-nextcloud Awaiting requested review from max-nextcloud

@susnux susnux Awaiting requested review from susnux

@vinicius73 vinicius73 Awaiting requested review from vinicius73

Assignees
No one assigned
Labels
2. developing bug Something isn't working design Experience, interaction, interface, …
Projects
None yet
Milestone
Nextcloud 25
Development

Successfully merging this pull request may close these issues.
4 participants
@vinicius73 @blizzz @mejo- @nextcloud-command