Refactor regex for keeping syntax to support Safari #2826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinicius73
approved these changes
Aug 24, 2022
susnux
approved these changes
Aug 24, 2022
|
/rebase |
Signed-off-by: Julius Härtl <jus@bitgrid.net>
nextcloud-command
force-pushed
the
bugfix/noid/keep-syntax-regex
branch
from
150961e
to
ab37a1f
Compare
|
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Safari does not support positive lookbehind expressions, so this PR refactors the regex matching to use capture groups.
https://caniuse.com/js-regexp-lookbehind