Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable24] Make cypress CI faster #2728

Merged
merged 3 commits into from
Jul 19, 2022
Merged

[stable24] Make cypress CI faster #2728

merged 3 commits into from
Jul 19, 2022

Conversation

juliusknorr
Copy link
Member

  • Reenable multiple cypress ocntainers
  • No need to build viewer anymore
  • Add one more container

Backport of #2494

Signed-off-by: Julius Härtl <jus@bitgrid.net>
The header does no longer autohide so we can skip the manual testing build

Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr added 3. to review tests If you write them we ♥ you labels Jul 19, 2022
@juliusknorr juliusknorr requested review from a team, vinicius73 and luka-nextcloud and removed request for a team July 19, 2022 07:15
@juliusknorr
Copy link
Member Author

juliusknorr commented Jul 19, 2022

Seems we have a bit of a flaky test on stable24:

@vinicius73 @max-nextcloud Does one of you remember a fix on master that we might be able to backport?

106

  1. Workspace
    107
    callouts
    108
    toggle callouts:
    109
    CypressError: Timed out retrying after 10050ms: cy.click() failed because this element is not visible:
    110
    111
    <button data-v-6469f3d2="" class="icon-info has-tooltip" data-original-title="null"></button>
    112
    113
    This element <button.icon-info.has-tooltip> is not visible because its parent <div.submenu> has CSS property: visibility: hidden
    114
    115
    Fix this problem, or use {force: true} to disable error checking.
    116
    117
    https://on.cypress.io/element-cannot-be-interacted-with
    118
    at runVisibilityCheck (http://localhost:8081/__cypress/runner/cypress_runner.js:168718:76)
    119
    at $Cy.ensureStrictVisibility (http://localhost:8081/__cypress/runner/cypress_runner.js:168734:12)
    120
    at runAllChecks (http://localhost:8081/__cypress/runner/cypress_runner.js:154692:14)
    121
    at retryActionability (http://localhost:8081/__cypress/runner/cypress_runner.js:154747:16)
    122
    at tryCatcher (http://localhost:8081/__cypress/runner/cypress_runner.js:13022:23)
    123
    at Function.Promise.attempt.Promise.try (http://localhost:8081/__cypress/runner/cypress_runner.js:10296:29)
    124
    at whenStable (http://localhost:8081/__cypress/runner/cypress_runner.js:173817:65)
    125
    at http://localhost:8081/__cypress/runner/cypress_runner.js:173272:14
    126
    at tryCatcher (http://localhost:8081/__cypress/runner/cypress_runner.js:13022:23)
    127
    at Promise._settlePromiseFromHandler (http://localhost:8081/__cypress/runner/cypress_runner.js:10957:31)
    128
    at Promise._settlePromise (http://localhost:8081/__cypress/runner/cypress_runner.js:11014:18)
    129
    at Promise._settlePromise0 (http://localhost:8081/__cypress/runner/cypress_runner.js:11059:10)
    130
    at Promise._settlePromises (http://localhost:8081/__cypress/runner/cypress_runner.js:11139:18)
    131
    at Promise._fulfill (http://localhost:8081/__cypress/runner/cypress_runner.js:11083:18)
    132
    at http://localhost:8081/__cypress/runner/cypress_runner.js:12697:46
    133
    From Your Spec Code:
    134
    at Context.eval (http://localhost:8081/__cypress/tests?p=cypress/integration/workspace.spec.js:2:5686)
    135
    136
    137
    138

@vinicius73
Copy link
Member

There are various improvements in cypress master branch.
Maybe We can manually apply some of then in stable24.

@juliusknorr juliusknorr merged commit 0122a7b into stable24 Jul 19, 2022
@delete-merged-branch delete-merged-branch bot deleted the ci/speed branch July 19, 2022 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review tests If you write them we ♥ you
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants