Task lists: Show label of done tasks crossed out #2724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
added
enhancement
|
My personal preference it the non-strikes through one as it keeps the items a bit more readable, but let's see what @jancborchardt and @nimishavijay think. |
|
That's somewhat true, but personally I agree with @jancborchardt on his comment:
|
juliusknorr
approved these changes
Jul 18, 2022
|
Yep, not a blocker from my side, just wanted to double check :) |
nimishavijay
approved these changes
Jul 18, 2022
|
/compile amend / |
As recommended in #886 this changes the styling of checked task list items to `line-through` and changes the color to `--color-text-maxcontrast`. Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
nextcloud-command
force-pushed
the
feat/styling-tasks
branch
from
c4ed72b to
8b2fba4
Compare
|
need a easy option to turn off the strike thru on checked items. do not want to mess with CSS to turn this off. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As recommended in #886 this changes the styling of
checked task list items to
line-throughand changesthe color to
var(--color-text-maxcontrast).Here is an example of how it looks like (also with dark color mode):
