Some backend cleanup #2719
Merged
Some backend cleanup #2719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
juliusknorr
commented
Jul 14, 2022
juliusknorr
commented
- Add type hints
- Move exceptions to dedicated namespace
- Get rid of ILogger in favour of the PSR LoggerInterface
juliusknorr
force-pushed
the
techdept/7.4
branch
from
56b3d00 to
92a07a5
Compare
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
vinicius73
pushed a commit
that referenced
this pull request
Jul 18, 2022
Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
vinicius73
approved these changes
Jul 18, 2022
vinicius73
pushed a commit
that referenced
this pull request
Jul 18, 2022
Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
|
Thanks for taking care of the interface adjustment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.