Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid saving without changes #2686

Merged
merged 4 commits into from
Aug 30, 2022
Merged

Avoid saving without changes #2686

merged 4 commits into from
Aug 30, 2022

Conversation

juliushaertl
Copy link
Member

@juliushaertl juliushaertl commented Jul 8, 2022 •
edited
Loading

First attempt towards fixing #2337

  • Test case for trailing node transaction triggering the step and save
  • Hotfix by appending a trailing paragraph before creating the tiptap document
    • Hopefully figure out a nicer way to solve this

@juliushaertl juliushaertl mentioned this pull request Jul 8, 2022
Closed
@juliushaertl juliushaertl added bug Something isn't working 2. developing labels Jul 8, 2022
@jancborchardt jancborchardt linked an issue Jul 18, 2022 that may be closed by this pull request
File open always triggers save and overwrites last modified date #2337
Closed
@vinicius73
Copy link
Member

/rebase

@vinicius73
Copy link
Member

/compile

@vinicius73
Copy link
Member

the expects now have a p tag 🙈

image

@juliushaertl
Copy link
Member Author

/compile

@juliushaertl
Copy link
Member Author

@vinicius73 Which would be expected so that we always end up with a new line. But I didn't see a failing CI check. Anyways rebased, so let's see.

@juliushaertl
Copy link
Member Author

Ah I see now, I'll have another look then.

@max-nextcloud
Copy link
Collaborator

/compile

@max-nextcloud max-nextcloud mentioned this pull request Aug 29, 2022
Open
@max-nextcloud
Copy link
Collaborator

Ahh.... i see. Tests still need to be updated.

juliushaertl and others added 3 commits August 30, 2022 11:55
@juliushaertl @max-nextcloud
Test that loading does not trigger a document change
cdfcd37 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliushaertl @max-nextcloud
Hotfix to always load tiptap with the trailing paragraph
2fa358f 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@max-nextcloud
tests: add paragraph to expected output
5c56006 
It was added to ensure the trailing paragraph extension of tiptap
does not trigger an autosave without other changes.

Signed-off-by: Max <max@nextcloud.com>
@max-nextcloud
Copy link
Collaborator

/backport to stable24

@max-nextcloud
Copy link
Collaborator

/backport to stable23

@max-nextcloud
Copy link
Collaborator

/compile

@max-nextcloud max-nextcloud self-requested a review August 30, 2022 09:56
max-nextcloud
max-nextcloud approved these changes Aug 30, 2022
View reviewed changes
Copy link
Collaborator

@max-nextcloud max-nextcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not ideal but seems to do the trick.

@nextcloud-command
Compile assets
8faa41e 
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@max-nextcloud max-nextcloud merged commit d9d622c into master Aug 30, 2022
@delete-merged-branch delete-merged-branch bot deleted the bugfix/2337 branch August 30, 2022 10:07
@backportbot-nextcloud
Copy link

The backport to stable24 failed. Please do this backport manually.

@backportbot-nextcloud
Copy link

The backport to stable23 failed. Please do this backport manually.

@blizzz blizzz mentioned this pull request Aug 30, 2022
Merged
@XueSheng-GIT XueSheng-GIT mentioned this pull request Oct 12, 2022
Closed
@juliushaertl juliushaertl mentioned this pull request Oct 28, 2022
Open
@juliushaertl
Copy link
Member Author

/backport cdfcd37,2fa358f8e7bfdc74158fa1e3a8b352db81806f25,5c56006d74a95396eb8492c45ca17d544f7d7a5e to stable24

@juliushaertl
Copy link
Member Author

/backport cdfcd37,2fa358f8e7bfdc74158fa1e3a8b352db81806f25,5c56006d74a95396eb8492c45ca17d544f7d7a5e to stable23

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Nov 3, 2022
Merged
@backportbot-nextcloud
Copy link

The backport to stable23 failed. Please do this backport manually.

This was referenced Nov 8, 2022
Closed
Closed
@meonkeys meonkeys mentioned this pull request Dec 30, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinicius73 vinicius73 vinicius73 left review comments

@max-nextcloud max-nextcloud max-nextcloud approved these changes

Assignees
No one assigned
Labels
2. developing bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

File open always triggers save and overwrites last modified date
4 participants
@juliushaertl @vinicius73 @max-nextcloud @nextcloud-command