Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow linking to directories in addition to linking to files. #2166

Conversation

rotdrop
Copy link

@rotdrop rotdrop commented Feb 7, 2022

The link syntax supported is:

[LINK_TEXT_AS_NORMAL](RELATIVE/PATH/WITH/TRAILING/SLASH/?fileId=FILE_ID_OF_DIRECTORY)

In the current implementation clicking on the link leads to a new tab or
window where the linked directory is shown.

The difference to the syntax for ordinary files is just the missing
file-name at the end.

Summary

The link syntax supported is:

[LINK_TEXT_AS_NORMAL](RELATIVE/PATH/WITH/TRAILING/SLASH/?fileId=FILE_ID_OF_DIRECTORY)

In the current implementation clicking on the link leads to a new tab or
window where the linked directory is shown.

The difference to the syntax for ordinary files is just the missing
file-name at the end.

Signed-off-by: Claus-Justus Heine <himself@claus-justus-heine.de>
@rotdrop rotdrop force-pushed the feature/allow-linking-to-cloud-directories branch from 3e7ae96 to 2bdc813 Compare February 8, 2022 08:42
@juliushaertl juliushaertl added 3. to review bug Something isn't working enhancement New feature or request and removed bug Something isn't working labels Feb 14, 2022
@juliushaertl
Copy link
Member

Thanks for your pull request. Looks sane code wise, but haven't tested yet. Since we had merged the tiptap v2 upgrade in the meantime could you maybe rebase your changes on top of latest master?

@juliushaertl juliushaertl added this to the Nextcloud 24 milestone Mar 7, 2022
@rotdrop
Copy link
Author

rotdrop commented Mar 17, 2022

Thanks for your pull request. Looks sane code wise, but haven't tested yet. Since we had merged the tiptap v2 upgrade in the meantime could you maybe rebase your changes on top of latest master?

I'll have a look, but not before mid of next week. Thanks for looking into my PR.

@vinicius73
Copy link
Member

I've tried to rebase the master branch into your code @rotdrop, but the source code changed a lot.
Now, this feature has changed to attach only images in the document, this is incompatible with this actual implementation.

Link folders and other files from internal storage still look like a good feature to have, we have to start it again.

We will probably bring back the 'add file link' feature soon and we will ping you and point you in the right direction to implement your feature.

@vinicius73 vinicius73 closed this Mar 31, 2022
@vinicius73 vinicius73 closed this Mar 31, 2022
@MichaIng MichaIng removed this from the Nextcloud 24 milestone Mar 31, 2022
@rotdrop
Copy link
Author

rotdrop commented May 24, 2022

I've tried to rebase the master branch into your code @rotdrop, but the source code changed a lot. Now, this feature has changed to attach only images in the document, this is incompatible with this actual implementation.

Well not quite, at least with NC 24. With the menu bubble linking to cloud-files is still possible, without any changes. I can eventually open another merge request.

And yes: some things have really changed a lot, and adding this to the main-menu seems no longer to be easy. Still, it works with the "menu-bubble".

Link folders and other files from internal storage still look like a good feature to have, we have to start it again.

We will probably bring back the 'add file link' feature soon and we will ping you and point you in the right direction to implement your feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow linking to folders
4 participants