Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add automatic line break on txt files #1883

Merged
merged 1 commit into from
Oct 27, 2021
Merged

Add automatic line break on txt files #1883

merged 1 commit into from
Oct 27, 2021

Conversation

luka-nextcloud
Copy link
Contributor

@luka-nextcloud luka-nextcloud commented Oct 4, 2021 •
edited by juliushaertl
Loading

Summary

image
image

juliushaertl
juliushaertl approved these changes Oct 5, 2021
View reviewed changes
Copy link
Member

@juliushaertl juliushaertl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, could you add the signed off message to the commit ?

@luka-nextcloud luka-nextcloud self-assigned this Oct 7, 2021
jancborchardt
jancborchardt approved these changes Oct 11, 2021
View reviewed changes
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! :)

julien-nc
julien-nc approved these changes Oct 11, 2021
View reviewed changes
Copy link
Member

@julien-nc julien-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice !

Could you rebase this on master?

@juliushaertl juliushaertl added 4. to release bug Something isn't working and removed 3. to review labels Oct 21, 2021
@juliushaertl juliushaertl added this to the Nextcloud 23 milestone Oct 21, 2021
@juliushaertl juliushaertl force-pushed the automatic-line-break-on-txt-files branch from 209b42b to 20d0696 Compare October 21, 2021 10:26
@azul azul force-pushed the automatic-line-break-on-txt-files branch from 20d0696 to f2636b0 Compare October 25, 2021 09:08
@luka-nextcloud luka-nextcloud force-pushed the automatic-line-break-on-txt-files branch from f2636b0 to 15a417d Compare October 25, 2021 09:27
@azul azul force-pushed the automatic-line-break-on-txt-files branch from 027c91b to f19d9c6 Compare October 25, 2021 10:11
@skjnldsv skjnldsv mentioned this pull request Oct 25, 2021
Merged
25 tasks
@luka-nextcloud @azul
fix line extending issue for txt file
e9a0a7d 
Signed-off-by: Luka Trovic <luka@nextcloud.com>
@azul azul force-pushed the automatic-line-break-on-txt-files branch from f19d9c6 to e9a0a7d Compare October 27, 2021 11:38
@azul azul merged commit 5190221 into master Oct 27, 2021
@delete-merged-branch delete-merged-branch bot deleted the automatic-line-break-on-txt-files branch October 27, 2021 11:55
@alabre
Copy link

alabre commented Oct 27, 2021

Thanks a lot! Looking forward to working with this. :-)

@juliushaertl
Copy link
Member

/backport to stable22

@juliushaertl
Copy link
Member

/backport to stable21

@juliushaertl
Copy link
Member

/backport to stable20

@backportbot-nextcloud
Copy link

The backport to stable22 failed. Please do this backport manually.

@backportbot-nextcloud
Copy link

The backport to stable21 failed. Please do this backport manually.

@backportbot-nextcloud
Copy link

The backport to stable20 failed. Please do this backport manually.

@dave-kennedy dave-kennedy mentioned this pull request Dec 29, 2021
Closed
@max-nextcloud max-nextcloud mentioned this pull request Jan 13, 2022
Merged
@max-nextcloud max-nextcloud added backported successfully backported and removed backport-request backported successfully backported labels Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jancborchardt jancborchardt jancborchardt approved these changes

@juliushaertl juliushaertl juliushaertl approved these changes

@julien-nc julien-nc julien-nc approved these changes

Assignees

@luka-nextcloud luka-nextcloud

Labels
4. to release bug Something isn't working
Projects
None yet
Milestone
Nextcloud 23
Development

Successfully merging this pull request may close these issues.

Lines extend beyond viewable area for .txt files
7 participants
@luka-nextcloud @alabre @juliushaertl @jancborchardt @julien-nc @azul @max-nextcloud